2020-11-16 12:22:24

by Zou Wei

[permalink] [raw]
Subject: [PATCH -next] ASoC: samsung: fix platform_no_drv_owner.cocci warnings

./sound/soc/samsung/midas_wm1811.c:534:3-8: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Signed-off-by: Zou Wei <[email protected]>
---
sound/soc/samsung/midas_wm1811.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/soc/samsung/midas_wm1811.c b/sound/soc/samsung/midas_wm1811.c
index d03340c..1f9a553 100644
--- a/sound/soc/samsung/midas_wm1811.c
+++ b/sound/soc/samsung/midas_wm1811.c
@@ -531,7 +531,6 @@ static struct platform_driver midas_driver = {
.driver = {
.name = "midas-audio",
.of_match_table = midas_of_match,
- .owner = THIS_MODULE,
.pm = &snd_soc_pm_ops,
},
.probe = midas_probe,
--
2.6.2


2020-11-17 19:48:13

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH -next] ASoC: samsung: fix platform_no_drv_owner.cocci warnings

On Mon, Nov 16, 2020 at 08:29:00PM +0800, Zou Wei wrote:
> ./sound/soc/samsung/midas_wm1811.c:534:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> sound/soc/samsung/midas_wm1811.c | 1 -
> 1 file changed, 1 deletion(-)
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2020-11-18 21:05:32

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH -next] ASoC: samsung: fix platform_no_drv_owner.cocci warnings

On Mon, 16 Nov 2020 20:29:00 +0800, Zou Wei wrote:
> ./sound/soc/samsung/midas_wm1811.c:534:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: samsung: fix platform_no_drv_owner.cocci warnings
commit: 45f366ec7941932d1a14576f3bd73d831fe9da95

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark