2020-11-19 04:50:19

by Nicolin Chen

[permalink] [raw]

Subject: [PATCH] soc/tegra: fuse: Fix index bug in get_process_id

---

This patch simply fixes a bug of referencing speedos[num] in every
for-loop iteration in get_process_id function.

Fixes: 0dc5a0d83675 ("soc/tegra: fuse: Add Tegra210 support")
Cc: <[email protected]>
Signed-off-by: Nicolin Chen <[email protected]>
---
drivers/soc/tegra/fuse/speedo-tegra210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/tegra/fuse/speedo-tegra210.c b/drivers/soc/tegra/fuse/speedo-tegra210.c
index 7394a8d694cb..695d0b7f9a8a 100644
--- a/drivers/soc/tegra/fuse/speedo-tegra210.c
+++ b/drivers/soc/tegra/fuse/speedo-tegra210.c
@@ -94,7 +94,7 @@ static int get_process_id(int value, const u32 *speedos, unsigned int num)
unsigned int i;

for (i = 0; i < num; i++)
- if (value < speedos[num])
+ if (value < speedos[i])
return i;

return -EINVAL;
--
2.17.1

2020-11-19 10:52:04

by Thierry Reding

[permalink] [raw]

Subject: Re: [PATCH] soc/tegra: fuse: Fix index bug in get_process_id

---

On Wed, Nov 18, 2020 at 08:44:57PM -0800, Nicolin Chen wrote:
> This patch simply fixes a bug of referencing speedos[num] in every
> for-loop iteration in get_process_id function.
>
> Fixes: 0dc5a0d83675 ("soc/tegra: fuse: Add Tegra210 support")
> Cc: <[email protected]>
> Signed-off-by: Nicolin Chen <[email protected]>
> ---
> drivers/soc/tegra/fuse/speedo-tegra210.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Good catch! Applied, thanks.

Thierry

---

Attachments:

(No filename) (492.00 B)
signature.asc (849.00 B)
Download all attachments