Hi Fabio,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c2e7554e1b85935d962127efa3c2a76483b0b3b6
commit: 17621758e53f0e6bf1ac469cca2a59fa6457d205 media: fsl-viu: Do not redefine out_be32()/in_be32() for CONFIG_M68K
date: 3 months ago
config: m68k-randconfig-r013-20201118 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=17621758e53f0e6bf1ac469cca2a59fa6457d205
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 17621758e53f0e6bf1ac469cca2a59fa6457d205
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
drivers/media/platform/fsl-viu.c: In function 'viu_start_dma':
>> drivers/media/platform/fsl-viu.c:253:2: error: implicit declaration of function 'out_be32' [-Werror=implicit-function-declaration]
253 | out_be32(&vr->status_cfg, SOFT_RST);
| ^~~~~~~~
drivers/media/platform/fsl-viu.c: In function 'viu_stop_dma':
>> drivers/media/platform/fsl-viu.c:266:15: error: implicit declaration of function 'in_be32' [-Werror=implicit-function-declaration]
266 | status_cfg = in_be32(&vr->status_cfg);
| ^~~~~~~
cc1: some warnings being treated as errors
vim +/out_be32 +253 drivers/media/platform/fsl-viu.c
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 245
adfcf2e980c4b61 drivers/media/platform/fsl-viu.c Mauro Carvalho Chehab 2018-04-05 246 static void viu_start_dma(struct viu_dev *dev)
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 247 {
27e4b6cfc970369 drivers/media/platform/fsl-viu.c Mauro Carvalho Chehab 2018-04-06 248 struct viu_reg __iomem *vr = dev->vr;
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 249
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 250 dev->field = 0;
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 251
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 252 /* Enable DMA operation */
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 @253 out_be32(&vr->status_cfg, SOFT_RST);
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 254 out_be32(&vr->status_cfg, INT_FIELD_EN);
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 255 }
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 256
adfcf2e980c4b61 drivers/media/platform/fsl-viu.c Mauro Carvalho Chehab 2018-04-05 257 static void viu_stop_dma(struct viu_dev *dev)
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 258 {
27e4b6cfc970369 drivers/media/platform/fsl-viu.c Mauro Carvalho Chehab 2018-04-06 259 struct viu_reg __iomem *vr = dev->vr;
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 260 int cnt = 100;
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 261 u32 status_cfg;
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 262
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 263 out_be32(&vr->status_cfg, 0);
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 264
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 265 /* Clear pending interrupts */
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 @266 status_cfg = in_be32(&vr->status_cfg);
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 267 if (status_cfg & 0x3f0000)
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 268 out_be32(&vr->status_cfg, status_cfg & 0x3f0000);
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 269
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 270 if (status_cfg & DMA_ACT) {
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 271 do {
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 272 status_cfg = in_be32(&vr->status_cfg);
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 273 if (status_cfg & INT_DMA_END_STATUS)
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 274 break;
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 275 } while (cnt--);
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 276
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 277 if (cnt < 0) {
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 278 /* timed out, issue soft reset */
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 279 out_be32(&vr->status_cfg, SOFT_RST);
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 280 out_be32(&vr->status_cfg, 0);
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 281 } else {
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 282 /* clear DMA_END and other pending irqs */
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 283 out_be32(&vr->status_cfg, status_cfg & 0x3f0000);
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 284 }
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 285 }
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 286
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 287 dev->field = 0;
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 288 }
95c5d605ca6fd6a drivers/media/video/fsl-viu.c Anatolij Gustschin 2010-07-02 289
:::::: The code at line 253 was first introduced by commit
:::::: 95c5d605ca6fd6ab5ab0f6d097ff97d5aa2f9235 V4L/DVB: v4l: Add MPC5121e VIU video capture driver
:::::: TO: Anatolij Gustschin <[email protected]>
:::::: CC: Mauro Carvalho Chehab <[email protected]>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
On Wed, Nov 18, 2020 at 10:15 PM kernel test robot <[email protected]> wrote:
>
> Hi Fabio,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: c2e7554e1b85935d962127efa3c2a76483b0b3b6
> commit: 17621758e53f0e6bf1ac469cca2a59fa6457d205 media: fsl-viu: Do not redefine out_be32()/in_be32() for CONFIG_M68K
> date: 3 months ago
> config: m68k-randconfig-r013-20201118 (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=17621758e53f0e6bf1ac469cca2a59fa6457d205
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout 17621758e53f0e6bf1ac469cca2a59fa6457d205
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> drivers/media/platform/fsl-viu.c: In function 'viu_start_dma':
> >> drivers/media/platform/fsl-viu.c:253:2: error: implicit declaration of function 'out_be32' [-Werror=implicit-function-declaration]
> 253 | out_be32(&vr->status_cfg, SOFT_RST);
> | ^~~~~~~~
> drivers/media/platform/fsl-viu.c: In function 'viu_stop_dma':
> >> drivers/media/platform/fsl-viu.c:266:15: error: implicit declaration of function 'in_be32' [-Werror=implicit-function-declaration]
> 266 | status_cfg = in_be32(&vr->status_cfg);
> | ^~~~~~~
> cc1: some warnings being treated as errors
It seems that Geert has submitted a proper fix a long time ago:
https://lkml.org/lkml/2020/8/17/2376