2020-11-20 18:39:57

by Gustavo A. R. Silva

Subject: [PATCH 108/141] netfilter: ipt_REJECT: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
net/ipv4/netfilter/ipt_REJECT.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/ipv4/netfilter/ipt_REJECT.c b/net/ipv4/netfilter/ipt_REJECT.c
index e16b98ee6266..7dbb10bbd0f5 100644
--- a/net/ipv4/netfilter/ipt_REJECT.c
+++ b/net/ipv4/netfilter/ipt_REJECT.c
@@ -57,6 +57,7 @@ reject_tg(struct sk_buff *skb, const struct xt_action_param *par)
break;
case IPT_TCP_RESET:
nf_send_reset(xt_net(par), skb, hook);
+ break;
case IPT_ICMP_ECHOREPLY:
/* Doesn't happen. */
break;
--
2.27.0

2020-11-20 22:52:33

by Florian Westphal

Subject: Re: [PATCH 108/141] netfilter: ipt_REJECT: Fix fall-through warnings for Clang

Gustavo A. R. Silva <[email protected]> wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.

Acked-by: Florian Westphal <[email protected]>

2020-11-25 02:08:10

by Gustavo A. R. Silva

Subject: Re: [PATCH 108/141] netfilter: ipt_REJECT: Fix fall-through warnings for Clang

On Fri, Nov 20, 2020 at 11:49:05PM +0100, Florian Westphal wrote:
> Gustavo A. R. Silva <[email protected]> wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of letting the code fall
> > through to the next case.
>
> Acked-by: Florian Westphal <[email protected]>

Thanks, Florian.
--
Gustavo