2020-11-26 10:39:04

by Sumera Priyadarsini

[permalink] [raw]
Subject: [PATCH v2] Documentation: Coccinelle: Improve command example for debugging patches

Modify Coccinelle documentation to clarify usage of make command to
run coccicheck on a folder.

Changes in v2:
- Give example of folder instead of file
- Add note

Signed-off-by: Sumera Priyadarsini <[email protected]>
---
Documentation/dev-tools/coccinelle.rst | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentation/dev-tools/coccinelle.rst
index 74c5e6aeeff5..9c454de5a7f7 100644
--- a/Documentation/dev-tools/coccinelle.rst
+++ b/Documentation/dev-tools/coccinelle.rst
@@ -224,14 +224,21 @@ you may want to use::

rm -f err.log
export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
- make coccicheck DEBUG_FILE="err.log" MODE=report SPFLAGS="--profile --show-trying" M=./drivers/mfd/arizona-irq.c
+ make coccicheck DEBUG_FILE="err.log" MODE=report SPFLAGS="--profile --show-trying" M=./drivers/mfd

err.log will now have the profiling information, while stdout will
provide some progress information as Coccinelle moves forward with
work.

+NOTE:
+
DEBUG_FILE support is only supported when using coccinelle >= 1.0.2.

+Currently, DEBUG_FILE support is only available to check folders, and
+not single files. This is because checking a single file requires spatch
+to be called twice leading to DEBUG_FILE being set both times to the same value,
+giving rise to an error.
+
.cocciconfig support
--------------------

--
2.25.1


2020-12-03 22:48:20

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH v2] Documentation: Coccinelle: Improve command example for debugging patches

On Thu, 26 Nov 2020 13:27:30 +0530
Sumera Priyadarsini <[email protected]> wrote:

> Modify Coccinelle documentation to clarify usage of make command to
> run coccicheck on a folder.
>
> Changes in v2:
> - Give example of folder instead of file
> - Add note
>
> Signed-off-by: Sumera Priyadarsini <[email protected]>
> ---
> Documentation/dev-tools/coccinelle.rst | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)

Applied, thanks.

jon