2020-11-27 08:50:39

by Jing Xiangfeng

Subject: [PATCH] scsi: storvsc: Fix error return in storvsc_probe()

Fix to return a error code "-ENOMEM" from the error handling case
instead of 0.

Fixes: 436ad9413353 ("scsi: storvsc: Allow only one remove lun work item to be issued per lun")
Signed-off-by: Jing Xiangfeng <[email protected]>
---
drivers/scsi/storvsc_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 0c65fbd41035..ded00a89bfc4 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1994,8 +1994,10 @@ static int storvsc_probe(struct hv_device *device,
alloc_ordered_workqueue("storvsc_error_wq_%d",
WQ_MEM_RECLAIM,
host->host_no);
- if (!host_dev->handle_error_wq)
+ if (!host_dev->handle_error_wq) {
+ ret = -ENOMEM;
goto err_out2;
+ }
INIT_WORK(&host_dev->host_scan_work, storvsc_host_scan);
/* Register the HBA and start the scsi bus scan */
ret = scsi_add_host(host, &device->device);
--
2.22.0

2020-11-29 16:49:40

by Michael Kelley (LINUX)

Subject: RE: [PATCH] scsi: storvsc: Fix error return in storvsc_probe()

From: Jing Xiangfeng <[email protected]> Sent: Thursday, November 26, 2020 7:02 PM
>
> Fix to return a error code "-ENOMEM" from the error handling case
> instead of 0.
>
> Fixes: 436ad9413353 ("scsi: storvsc: Allow only one remove lun work item to be issued per
> lun")
> Signed-off-by: Jing Xiangfeng <[email protected]>
> ---
> drivers/scsi/storvsc_drv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 0c65fbd41035..ded00a89bfc4 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1994,8 +1994,10 @@ static int storvsc_probe(struct hv_device *device,
> alloc_ordered_workqueue("storvsc_error_wq_%d",
> WQ_MEM_RECLAIM,
> host->host_no);
> - if (!host_dev->handle_error_wq)
> + if (!host_dev->handle_error_wq) {
> + ret = -ENOMEM;
> goto err_out2;
> + }
> INIT_WORK(&host_dev->host_scan_work, storvsc_host_scan);
> /* Register the HBA and start the scsi bus scan */
> ret = scsi_add_host(host, &device->device);
> --
> 2.22.0

Reviewed-by: Michael Kelley <[email protected]>

2020-12-01 06:10:52

by Martin K. Petersen

Subject: Re: [PATCH] scsi: storvsc: Fix error return in storvsc_probe()

On Fri, 27 Nov 2020 11:02:06 +0800, Jing Xiangfeng wrote:

> Fix to return a error code "-ENOMEM" from the error handling case
> instead of 0.

Applied to 5.10/scsi-fixes, thanks!

[1/1] scsi: storvsc: Fix error return in storvsc_probe()
https://git.kernel.org/mkp/scsi/c/6112ff4e8f39

--
Martin K. Petersen Oracle Linux Engineering