2020-11-27 12:39:54

by Oleksij Rempel

Subject: [PATCH v1] net: phy: micrel: fix interrupt handling

After migration to the shared interrupt support, the KSZ8031 PHY with
enabled interrupt support was not able to notify about link status
change.

Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
Signed-off-by: Oleksij Rempel <[email protected]>
---
drivers/net/phy/micrel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 97f08f20630b..54e0d75203da 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -207,7 +207,7 @@ static irqreturn_t kszphy_handle_interrupt(struct phy_device *phydev)
return IRQ_NONE;
}

- if ((irq_status & KSZPHY_INTCS_STATUS))
+ if (!(irq_status & KSZPHY_INTCS_STATUS))
return IRQ_NONE;

phy_trigger_machine(phydev);
--
2.29.2

2020-11-27 14:49:13

by Andrew Lunn

Subject: Re: [PATCH v1] net: phy: micrel: fix interrupt handling

On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote:
> After migration to the shared interrupt support, the KSZ8031 PHY with
> enabled interrupt support was not able to notify about link status
> change.
>
> Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
> Signed-off-by: Oleksij Rempel <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

I took a quick look at all the other patches like this. I did not spot
any other missing the !

Andrew

2020-11-27 15:15:21

by Ioana Ciornei

Subject: Re: [PATCH v1] net: phy: micrel: fix interrupt handling

On Fri, Nov 27, 2020 at 03:45:45PM +0100, Andrew Lunn wrote:
> On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote:
> > After migration to the shared interrupt support, the KSZ8031 PHY with
> > enabled interrupt support was not able to notify about link status
> > change.
> >
> > Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
> > Signed-off-by: Oleksij Rempel <[email protected]>
>
> Reviewed-by: Andrew Lunn <[email protected]>
>
> I took a quick look at all the other patches like this. I did not spot
> any other missing the !
>
> Andrew

Uhh, really sorry for this!

Thanks for double checking.

Ioana

2020-11-28 02:27:40

by Jakub Kicinski

Subject: Re: [PATCH v1] net: phy: micrel: fix interrupt handling

On Fri, 27 Nov 2020 15:11:08 +0000 Ioana Ciornei wrote:
> On Fri, Nov 27, 2020 at 03:45:45PM +0100, Andrew Lunn wrote:
> > On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote:
> > > After migration to the shared interrupt support, the KSZ8031 PHY with
> > > enabled interrupt support was not able to notify about link status
> > > change.
> > >
> > > Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
> > > Signed-off-by: Oleksij Rempel <[email protected]>
> >
> > Reviewed-by: Andrew Lunn <[email protected]>
> >
> > I took a quick look at all the other patches like this. I did not spot
> > any other missing the !
> >
> > Andrew
>
> Uhh, really sorry for this!
>
> Thanks for double checking.

Applied, thanks!