2020-11-26 20:11:34

by Tian Tao

Subject: [PATCH] hwmon: (abx500): Switch to using the new API kobj_to_dev()

fixed the following coccicheck:
drivers/hwmon/abx500.c:266:60-61: WARNING opportunity for kobj_to_dev().

Signed-off-by: Tian Tao <[email protected]>
---
drivers/hwmon/abx500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/abx500.c b/drivers/hwmon/abx500.c
index 50e67cd..4b96488 100644
--- a/drivers/hwmon/abx500.c
+++ b/drivers/hwmon/abx500.c
@@ -263,7 +263,7 @@ static ssize_t max_alarm_show(struct device *dev,
static umode_t abx500_attrs_visible(struct kobject *kobj,
struct attribute *attr, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct abx500_temp *data = dev_get_drvdata(dev);

if (data->ops.is_visible)
--
2.7.4

2020-11-27 15:44:23

by Guenter Roeck

Subject: Re: [PATCH] hwmon: (abx500): Switch to using the new API kobj_to_dev()

On Thu, Nov 26, 2020 at 10:21:20AM +0800, Tian Tao wrote:
> fixed the following coccicheck:
> drivers/hwmon/abx500.c:266:60-61: WARNING opportunity for kobj_to_dev().
>
> Signed-off-by: Tian Tao <[email protected]>

Applied.

Thanks,
Guenter

> ---
> drivers/hwmon/abx500.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/abx500.c b/drivers/hwmon/abx500.c
> index 50e67cd..4b96488 100644
> --- a/drivers/hwmon/abx500.c
> +++ b/drivers/hwmon/abx500.c
> @@ -263,7 +263,7 @@ static ssize_t max_alarm_show(struct device *dev,
> static umode_t abx500_attrs_visible(struct kobject *kobj,
> struct attribute *attr, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct abx500_temp *data = dev_get_drvdata(dev);
>
> if (data->ops.is_visible)