2020-11-30 06:09:50

by Dongjin Kim

Subject: [PATCH v2] arm64: dts: meson-sm1: fix typo in opp table

The freqency 1512000000 should be 1500000000.

Signed-off-by: Dongjin Kim <[email protected]>
---

Change in v2:
- wrong fix in the previous patch.
https://patchwork.kernel.org/project/linux-amlogic/patch/20201130054221.GA25448@anyang-linuxfactory-or-kr/

---
arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
index 71317f5aada1..c309517abae3 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
@@ -130,7 +130,7 @@
opp-microvolt = <790000>;
};

- opp-1512000000 {
+ opp-1500000000 {
opp-hz = /bits/ 64 <1500000000>;
opp-microvolt = <800000>;
};
--
2.17.1

2020-11-30 13:27:16

by Neil Armstrong

Subject: Re: [PATCH v2] arm64: dts: meson-sm1: fix typo in opp table

On 30/11/2020 07:03, Dongjin Kim wrote:
> The freqency 1512000000 should be 1500000000.
>

Fixes: 3d9e76483049 ("arm64: dts: meson-sm1-sei610: enable DVFS")

> Signed-off-by: Dongjin Kim <[email protected]>
> ---
>
> Change in v2:
> - wrong fix in the previous patch.
> https://patchwork.kernel.org/project/linux-amlogic/patch/20201130054221.GA25448@anyang-linuxfactory-or-kr/
>
> ---
> arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
> index 71317f5aada1..c309517abae3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
> @@ -130,7 +130,7 @@
> opp-microvolt = <790000>;
> };
>
> - opp-1512000000 {
> + opp-1500000000 {
> opp-hz = /bits/ 64 <1500000000>;
> opp-microvolt = <800000>;
> };
>

Reviewed-by: Neil Armstrong <[email protected]>

2020-12-05 18:37:32

by Martin Blumenstingl

Subject: Re: [PATCH v2] arm64: dts: meson-sm1: fix typo in opp table

On Mon, Nov 30, 2020 at 7:04 AM Dongjin Kim <[email protected]> wrote:
>
> The freqency 1512000000 should be 1500000000.
there's a typo in "frequency". I hope that Kevin can fix this up while
applying the patch

>
> Signed-off-by: Dongjin Kim <[email protected]>
apart from the typo above:
Reviewed-by: Martin Blumenstingl <[email protected]>
(while reviewing I noticed that we generally use 0.3V less for each
OPP table step than the downstream kvim3l.dts - that's a discussion we
need to have elsewhere though)