2020-11-30 11:32:42

by ZHIZHIKIN Andrey

[permalink] [raw]
Subject: [PATCH 0/2] drop unused POWER_AVS option for ARM/ARM64 config

This series cleans up kernel config files, removing the unused POWER_AVS
option.

It has been removed in commit 785b5bb41b0a ("PM: AVS: Drop the avs
directory and the corresponding Kconfig"), from the tree and
therefore should be removed frorm default config files delivered for ARM
and ARM64 builds.

Andrey Zhizhikin (2):
arm64: defconfig: drop unused POWER_AVS option
ARM: multi_v7_defconfig: drop unused POWER_AVS option

arch/arm/configs/multi_v7_defconfig | 1 -
arch/arm64/configs/defconfig | 1 -
2 files changed, 2 deletions(-)

--
2.17.1


2020-11-30 11:33:41

by ZHIZHIKIN Andrey

[permalink] [raw]
Subject: [PATCH 2/2] ARM: multi_v7_defconfig: drop unused POWER_AVS option

Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
corresponding Kconfig") moved AVS code to SOC-specific folders, and
removed corresponding Kconfig from drivers/power, leaving original
POWER_AVS config option enabled in multi_v7_defconfig file.

Remove the option, which has no references in the tree anymore.

Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the corresponding Kconfig")
Cc: Nishanth Menon <[email protected]>
Cc: Ulf Hansson <[email protected]>
Signed-off-by: Andrey Zhizhikin <[email protected]>
---
arch/arm/configs/multi_v7_defconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index a611b0c1e540..91752d918d34 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -466,7 +466,6 @@ CONFIG_GPIO_TPS6586X=y
CONFIG_GPIO_TPS65910=y
CONFIG_GPIO_TWL4030=y
CONFIG_GPIO_MXC=y
-CONFIG_POWER_AVS=y
CONFIG_ROCKCHIP_IODOMAIN=y
CONFIG_POWER_RESET_AS3722=y
CONFIG_POWER_RESET_GPIO=y
--
2.17.1

2020-11-30 11:34:13

by ZHIZHIKIN Andrey

[permalink] [raw]
Subject: [PATCH 1/2] arm64: defconfig: drop unused POWER_AVS option

Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
corresponding Kconfig") moved AVS code to SOC-specific folders, and
removed corresponding Kconfig from drivers/power, leaving original
POWER_AVS config option enabled in defconfig file.

Remove the option, which has no references in the tree anymore.

Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the corresponding Kconfig")
Cc: Nishanth Menon <[email protected]>
Cc: Ulf Hansson <[email protected]>
Signed-off-by: Andrey Zhizhikin <[email protected]>
---
arch/arm64/configs/defconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 5cfe3cf6f2ac..8e3f7ae71de5 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -513,7 +513,6 @@ CONFIG_GPIO_PCA953X_IRQ=y
CONFIG_GPIO_BD9571MWV=m
CONFIG_GPIO_MAX77620=y
CONFIG_GPIO_SL28CPLD=m
-CONFIG_POWER_AVS=y
CONFIG_QCOM_CPR=y
CONFIG_ROCKCHIP_IODOMAIN=y
CONFIG_POWER_RESET_MSM=y
--
2.17.1

2020-11-30 12:09:01

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: defconfig: drop unused POWER_AVS option

On Mon, Nov 30, 2020 at 11:27:30AM +0000, Andrey Zhizhikin wrote:
> Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
> corresponding Kconfig") moved AVS code to SOC-specific folders, and
> removed corresponding Kconfig from drivers/power, leaving original
> POWER_AVS config option enabled in defconfig file.
>
> Remove the option, which has no references in the tree anymore.
>
> Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the corresponding Kconfig")
> Cc: Nishanth Menon <[email protected]>
> Cc: Ulf Hansson <[email protected]>
> Signed-off-by: Andrey Zhizhikin <[email protected]>
> ---
> arch/arm64/configs/defconfig | 1 -
> 1 file changed, 1 deletion(-)
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2020-11-30 12:25:05

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH 2/2] ARM: multi_v7_defconfig: drop unused POWER_AVS option

On 11:27-20201130, Andrey Zhizhikin wrote:
> Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
> corresponding Kconfig") moved AVS code to SOC-specific folders, and
> removed corresponding Kconfig from drivers/power, leaving original
> POWER_AVS config option enabled in multi_v7_defconfig file.
>
> Remove the option, which has no references in the tree anymore.
>
> Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the corresponding Kconfig")
> Cc: Nishanth Menon <[email protected]>
> Cc: Ulf Hansson <[email protected]>
> Signed-off-by: Andrey Zhizhikin <[email protected]>

Reviewed-by: Nishanth Menon <[email protected]>

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2020-11-30 12:25:22

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: defconfig: drop unused POWER_AVS option

On 11:27-20201130, Andrey Zhizhikin wrote:
> Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
> corresponding Kconfig") moved AVS code to SOC-specific folders, and
> removed corresponding Kconfig from drivers/power, leaving original
> POWER_AVS config option enabled in defconfig file.
>
> Remove the option, which has no references in the tree anymore.
>
> Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the corresponding Kconfig")
> Cc: Nishanth Menon <[email protected]>
> Cc: Ulf Hansson <[email protected]>
> Signed-off-by: Andrey Zhizhikin <[email protected]>

Reviewed-by: Nishanth Menon <[email protected]>


--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2020-11-30 12:26:10

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] ARM: multi_v7_defconfig: drop unused POWER_AVS option

On Mon, Nov 30, 2020 at 11:27:31AM +0000, Andrey Zhizhikin wrote:
> Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
> corresponding Kconfig") moved AVS code to SOC-specific folders, and
> removed corresponding Kconfig from drivers/power, leaving original
> POWER_AVS config option enabled in multi_v7_defconfig file.
>
> Remove the option, which has no references in the tree anymore.
>
> Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the corresponding Kconfig")
> Cc: Nishanth Menon <[email protected]>
> Cc: Ulf Hansson <[email protected]>
> Signed-off-by: Andrey Zhizhikin <[email protected]>

Thanks for the patch. You should also remove it from the omap2plus config.

Best regards,
Krzysztof

2020-11-30 12:40:36

by ZHIZHIKIN Andrey

[permalink] [raw]
Subject: RE: [PATCH 2/2] ARM: multi_v7_defconfig: drop unused POWER_AVS option

Hello Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Monday, November 30, 2020 1:23 PM
> To: ZHIZHIKIN Andrey <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; Nishanth Menon <[email protected]>; Ulf Hansson
> <[email protected]>
> Subject: Re: [PATCH 2/2] ARM: multi_v7_defconfig: drop unused
> POWER_AVS option
>
> This email is not from Hexagon’s Office 365 instance. Please be careful while
> clicking links, opening attachments, or replying to this email.
>
>
> On Mon, Nov 30, 2020 at 11:27:31AM +0000, Andrey Zhizhikin wrote:
> > Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
> > corresponding Kconfig") moved AVS code to SOC-specific folders, and
> > removed corresponding Kconfig from drivers/power, leaving original
> > POWER_AVS config option enabled in multi_v7_defconfig file.
> >
> > Remove the option, which has no references in the tree anymore.
> >
> > Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
> > corresponding Kconfig")
> > Cc: Nishanth Menon <[email protected]>
> > Cc: Ulf Hansson <[email protected]>
> > Signed-off-by: Andrey Zhizhikin
> > <[email protected]>
>
> Thanks for the patch. You should also remove it from the omap2plus config.

True, just realized this config option is present in arch/arm/configs/omap2plus_defconfig. Thanks for pointing this out, would submit a separate patch to take care of it now.

>
> Best regards,
> Krzysztof

Regards,
Andrey

2020-11-30 13:01:33

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] ARM: multi_v7_defconfig: drop unused POWER_AVS option

On Mon, Nov 30, 2020 at 11:27:31AM +0000, Andrey Zhizhikin wrote:
> Commit 785b5bb41b0a ("PM: AVS: Drop the avs directory and the
> corresponding Kconfig") moved AVS code to SOC-specific folders, and
> removed corresponding Kconfig from drivers/power, leaving original
> POWER_AVS config option enabled in multi_v7_defconfig file.
>
> Remove the option, which has no references in the tree anymore.
>
> Fixes: 785b5bb41b0a ("PM: AVS: Drop the avs directory and the corresponding Kconfig")
> Cc: Nishanth Menon <[email protected]>
> Cc: Ulf Hansson <[email protected]>
> Signed-off-by: Andrey Zhizhikin <[email protected]>
> ---
> arch/arm/configs/multi_v7_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2020-12-20 15:11:55

by ZHIZHIKIN Andrey

[permalink] [raw]
Subject: RE: [PATCH 0/2] drop unused POWER_AVS option for ARM/ARM64 config

Hello Arnd,

A while ago, I've submitted this series to clean-up the unused POWER_AVS config option, and
It looks like it did not land in anyone's tree until now.

Similar patch to clean-up the same option in omap2plus_defconfig has been already picked up
by Tony Lindgren and is already present in the linux-next tree, commit 0437141b4e22 ("ARM:
configs: drop unused BACKLIGHT_GENERIC option").

Series has been already reviewed by Krzysztof and Nishanth, but nobody seems to pick it up further.

Since at the time of sending this series, I was not aware that ARM SOC list should also be included
(same thing as for BACKLIGHT_GENERIC series [1]), I wanted to ask you if you can take care of this
series further as it does touch the multi config for arm32 and aarch64.

Or should I re-send the series with collected tags and include ARM SOC list (same as I did for
BACKLIGHT_GENERIC [1])?

> -----Original Message-----
> From: ZHIZHIKIN Andrey <[email protected]>
> Sent: Monday, November 30, 2020 12:27 PM
> To: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; linux-
> [email protected]
> Cc: ZHIZHIKIN Andrey <[email protected]>
> Subject: [PATCH 0/2] drop unused POWER_AVS option for ARM/ARM64 config
>
> This series cleans up kernel config files, removing the unused POWER_AVS
> option.
>
> It has been removed in commit 785b5bb41b0a ("PM: AVS: Drop the avs
> directory and the corresponding Kconfig"), from the tree and
> therefore should be removed frorm default config files delivered for ARM
> and ARM64 builds.
>
> Andrey Zhizhikin (2):
> arm64: defconfig: drop unused POWER_AVS option
> ARM: multi_v7_defconfig: drop unused POWER_AVS option
>
> arch/arm/configs/multi_v7_defconfig | 1 -
> arch/arm64/configs/defconfig | 1 -
> 2 files changed, 2 deletions(-)
>
> --
> 2.17.1

Link: [1]: https://lore.kernel.org/linux-arm-kernel/[email protected]/

-- Andrey