2020-11-30 23:04:38

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH] ASoC: adau1372: add missing dependencies

On 30/11/2020 22:56:26+0100, Alexandre Belloni wrote:
> SND_SOC_ADAU1372_I2C and SND_SOC_ADAU1372_SPI prpoerly select the REGMAP
> config they need but forget to depend on the underlying bus.
>
> Signed-off-by: Alexandre Belloni <[email protected]>

I forgot:

Reported-by: kernel test robot <[email protected]>

> ---
> sound/soc/codecs/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index a457300f95da..625f762903ea 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -371,11 +371,13 @@ config SND_SOC_ADAU1372
>
> config SND_SOC_ADAU1372_I2C
> tristate "Analog Devices ADAU1372 CODEC (I2C)"
> + depends on I2C
> select SND_SOC_ADAU1372
> select REGMAP_I2C
>
> config SND_SOC_ADAU1372_SPI
> tristate "Analog Devices ADAU1372 CODEC (SPI)"
> + depends on SPI
> select SND_SOC_ADAU1372
> select REGMAP_SPI
>
> --
> 2.28.0
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com