Hi Vinod,
After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file or directory
17 | #include <mt7621.h>
| ^~~~~~~~~~
This driver has two includes which are in
"arch/mips/include/asm/mach-ralink" and are directly included in the
driver:
* mt7621.h
* ralink_regs.h
This is because this path is directly included in 'arch/mips/ralink/Platform'
for "ralink".
Adding the include search path to the phy ralink directory fix the problem.
Making 'allmodconfig' in x86_64 also showed two warnings for this driver
because of pointer size and not valid name for MODULE_DEVICE_TABLE ids.
This two have been also fixed and included in this series.
Best regards,
Sergio Paracuellos
Sergio Paracuellos (3):
phy: ralink: phy-mt7621-pci: add include search path in Makefile
phy: ralink: phy-mt7621-pci: avoid warning if COMPILE_TEST is enabled
phy: ralink: phy-mt7621-pci: set correct name in MODULE_DEVICE_TABLE
macro
drivers/phy/ralink/Makefile | 3 +++
drivers/phy/ralink/phy-mt7621-pci.c | 6 +++---
2 files changed, 6 insertions(+), 3 deletions(-)
--
2.25.1
Correct name passed into 'MODULE_DEVICE_TABLE' which was wrong and
was showing a warning when the driver is enabled for 'COMPILE_TEST'.
Signed-off-by: Sergio Paracuellos <[email protected]>
---
drivers/phy/ralink/phy-mt7621-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/ralink/phy-mt7621-pci.c b/drivers/phy/ralink/phy-mt7621-pci.c
index befa282e2447..072f848ec0cf 100644
--- a/drivers/phy/ralink/phy-mt7621-pci.c
+++ b/drivers/phy/ralink/phy-mt7621-pci.c
@@ -335,7 +335,7 @@ static const struct of_device_id mt7621_pci_phy_ids[] = {
{ .compatible = "mediatek,mt7621-pci-phy" },
{},
};
-MODULE_DEVICE_TABLE(of, mt7621_pci_ids);
+MODULE_DEVICE_TABLE(of, mt7621_pci_phy_ids);
static struct platform_driver mt7621_pci_phy_driver = {
.probe = mt7621_pci_phy_probe,
--
2.25.1
This driver includes the following two files directly:
- mt7621.h
- ralink_regs.h
Compilation for its related platform properly works because
its real path is included in 'arch/mips/ralink/Platform' as
cflags.
This driver depends on RALINK but also is enabled for COMPILE_TEST
where nothing about its platform is known and this directly
included files are not found at all breaking compilation.
Fix this problem adding include search path for ralink in
ralink phy directory Makefile.
Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
Signed-off-by: Sergio Paracuellos <[email protected]>
---
drivers/phy/ralink/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/phy/ralink/Makefile b/drivers/phy/ralink/Makefile
index cda2a4a7ca5e..c8f9adba0d82 100644
--- a/drivers/phy/ralink/Makefile
+++ b/drivers/phy/ralink/Makefile
@@ -1,3 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
+
+ccflags-y += -I$(srctree)/arch/mips/include/asm/mach-ralink
+
obj-$(CONFIG_PHY_MT7621_PCI) += phy-mt7621-pci.o
obj-$(CONFIG_PHY_RALINK_USB) += phy-ralink-usb.o
--
2.25.1