Hi Vinod,
After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file or directory
17 | #include <mt7621.h>
| ^~~~~~~~~~
This driver has two includes which are in
"arch/mips/include/asm/mach-ralink" and are directly included in the
driver:
* mt7621.h
* ralink_regs.h
This is because this path is directly included in 'arch/mips/ralink/Platform'
for "ralink".
Adding the include search path to the phy ralink directory fix the problem but
as you told me I finally end up removing COMPILE_TEST from Kconfig.
Making 'allmodconfig' in x86_64 also showed two warnings for this driver
because of pointer size and not valid name for MODULE_DEVICE_TABLE ids.
Ids for the macro has been also included in this series.
Changes in v3:
- PATCH 1/3 completely changed:
- Makefile is not touched.
- Drop 'COMPILE_TEST' in Kconfig.
- Drop PATCH 2/3 in previous series because COMPILE_TEST does not apply anymore.
Changes in v2:
- Added 'Reported-by' tag in PATCH 1/3.
Best regards,
Sergio Paracuellos
Sergio Paracuellos (2):
phy: ralink: phy-mt7621-pci: drop 'COMPILE_TEST' from Kconfig
phy: ralink: phy-mt7621-pci: set correct name in MODULE_DEVICE_TABLE
macro
drivers/phy/ralink/Kconfig | 2 +-
drivers/phy/ralink/phy-mt7621-pci.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.25.1
On Tue, Dec 1, 2020 at 12:44 PM Vinod Koul <[email protected]> wrote:
>
> On 01-12-20, 12:20, Sergio Paracuellos wrote:
> > Hi Vinod,
> >
> > After merging the phy-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file or directory
> > 17 | #include <mt7621.h>
> > | ^~~~~~~~~~
> >
> > This driver has two includes which are in
> > "arch/mips/include/asm/mach-ralink" and are directly included in the
> > driver:
> > * mt7621.h
> > * ralink_regs.h
> >
> > This is because this path is directly included in 'arch/mips/ralink/Platform'
> > for "ralink".
> >
> > Adding the include search path to the phy ralink directory fix the problem but
> > as you told me I finally end up removing COMPILE_TEST from Kconfig.
> >
> > Making 'allmodconfig' in x86_64 also showed two warnings for this driver
> > because of pointer size and not valid name for MODULE_DEVICE_TABLE ids.
> >
> > Ids for the macro has been also included in this series.
>
> Applied, thanks
>
Thanks for letting me know.
Best regards,
Sergio Paracuellos
> --
> ~Vinod
This driver includes the following two files directly:
- mt7621.h
- ralink_regs.h
Compilation for its related platform properly works because
its real path is included in 'arch/mips/ralink/Platform' as
cflags.
This driver depends on RALINK but also is enabled for COMPILE_TEST
where nothing about its platform is known and this directly
included files are not found at all breaking compilation.
If we want 'COMPILE_TEST' we have to change cflags also inside
'phy/ralink' subdirectory Makefile which seems that does not
like to linux-phy maintainers. Hence remove COMPILE_TEST from
Kconfig to avoid the problem.
Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Sergio Paracuellos <[email protected]>
---
drivers/phy/ralink/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/ralink/Kconfig b/drivers/phy/ralink/Kconfig
index 2fabb14d2998..ecc309ba9fee 100644
--- a/drivers/phy/ralink/Kconfig
+++ b/drivers/phy/ralink/Kconfig
@@ -4,7 +4,7 @@
#
config PHY_MT7621_PCI
tristate "MediaTek MT7621 PCI PHY Driver"
- depends on (RALINK || COMPILE_TEST) && OF
+ depends on RALINK && OF
select GENERIC_PHY
select REGMAP_MMIO
help
--
2.25.1
On 01-12-20, 12:20, Sergio Paracuellos wrote:
> Hi Vinod,
>
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file or directory
> 17 | #include <mt7621.h>
> | ^~~~~~~~~~
>
> This driver has two includes which are in
> "arch/mips/include/asm/mach-ralink" and are directly included in the
> driver:
> * mt7621.h
> * ralink_regs.h
>
> This is because this path is directly included in 'arch/mips/ralink/Platform'
> for "ralink".
>
> Adding the include search path to the phy ralink directory fix the problem but
> as you told me I finally end up removing COMPILE_TEST from Kconfig.
>
> Making 'allmodconfig' in x86_64 also showed two warnings for this driver
> because of pointer size and not valid name for MODULE_DEVICE_TABLE ids.
>
> Ids for the macro has been also included in this series.
Applied, thanks
--
~Vinod