2020-12-01 12:00:29

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH v5 1/6] dt-bindings: display: simple: Add EDT ETM0700G0BDH6 display

Hi Oleksij

On Tue, Dec 01, 2020 at 10:27:37AM +0100, Oleksij Rempel wrote:
> This display is already supported by the panel-simple driver, so add it
> to the bindings documentation.
>
> This patch is needed to fix checkpatch warnings for the PLYM2M dts.
>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index edb53ab0d9eb..a011d9e44af3 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -117,6 +117,8 @@ properties:
> - edt,etm0700g0dh6
> # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> # Same as ETM0700G0DH6 but with inverted pixel clock.
> + - edt,etm0700g0bdh6
> + # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> - edt,etm070080bdh6
> # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> # Same display as the ETM0700G0BDH6, but with changed hardware for the

The panels should be listed in alphabetic order which is not the case
here. Could you fix the alphabetic order for the edt panels and then
insert the new panel in the right spot?

Sam


2020-12-02 08:21:08

by Oleksij Rempel

[permalink] [raw]
Subject: Re: [PATCH v5 1/6] dt-bindings: display: simple: Add EDT ETM0700G0BDH6 display

On Tue, Dec 01, 2020 at 12:56:12PM +0100, Sam Ravnborg wrote:
> Hi Oleksij
>
> On Tue, Dec 01, 2020 at 10:27:37AM +0100, Oleksij Rempel wrote:
> > This display is already supported by the panel-simple driver, so add it
> > to the bindings documentation.
> >
> > This patch is needed to fix checkpatch warnings for the PLYM2M dts.
> >
> > Signed-off-by: Oleksij Rempel <[email protected]>
> > ---
> > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > index edb53ab0d9eb..a011d9e44af3 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > @@ -117,6 +117,8 @@ properties:
> > - edt,etm0700g0dh6
> > # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > # Same as ETM0700G0DH6 but with inverted pixel clock.
> > + - edt,etm0700g0bdh6
> > + # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > - edt,etm070080bdh6
> > # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> > # Same display as the ETM0700G0BDH6, but with changed hardware for the
>
> The panels should be listed in alphabetic order which is not the case
> here. Could you fix the alphabetic order for the edt panels and then
> insert the new panel in the right spot?

ack, will be done

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |