Subject: [PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call

Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose.
For in-kernel drivers, the kernel version matters. The driver received lots
of changes, but version number has remained the same since it's introducing
into mainline, seven years ago. So, it doesn't seem to have much practical
meaning anymore.

Signed-off-by: Enrico Weigelt <[email protected]>
---
drivers/staging/goldfish/goldfish_audio.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
index 0c65a0121dde..4a23f40e549a 100644
--- a/drivers/staging/goldfish/goldfish_audio.c
+++ b/drivers/staging/goldfish/goldfish_audio.c
@@ -24,7 +24,6 @@
MODULE_AUTHOR("Google, Inc.");
MODULE_DESCRIPTION("Android QEMU Audio Driver");
MODULE_LICENSE("GPL");
-MODULE_VERSION("1.0");

struct goldfish_audio {
char __iomem *reg_base;
--
2.11.0


2020-12-04 15:51:14

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call

On Thu, Dec 03, 2020 at 01:47:56PM +0100, Enrico Weigelt, metux IT consult wrote:
> Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose.
> For in-kernel drivers, the kernel version matters. The driver received lots
> of changes, but version number has remained the same since it's introducing
> into mainline, seven years ago. So, it doesn't seem to have much practical
> meaning anymore.
>
> Signed-off-by: Enrico Weigelt <[email protected]>
> ---
> drivers/staging/goldfish/goldfish_audio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
> index 0c65a0121dde..4a23f40e549a 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -24,7 +24,6 @@
> MODULE_AUTHOR("Google, Inc.");
> MODULE_DESCRIPTION("Android QEMU Audio Driver");
> MODULE_LICENSE("GPL");
> -MODULE_VERSION("1.0");
>
> struct goldfish_audio {
> char __iomem *reg_base;

This file isn't even in my tree, are you sure you made this patch series
against the correct branch/tree?

Please fix this series up and resend.

thanks,

greg k-h