From: Arnd Bergmann <[email protected]>
If this is not enabled, the interfaces used in this driver do not work:
drivers/i2c/busses/i2c-mlxbf.c:1888:3: error: implicit declaration of function 'i2c_slave_event' [-Werror,-Wimplicit-function-declaration]
i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
^
drivers/i2c/busses/i2c-mlxbf.c:1888:26: error: use of undeclared identifier 'I2C_SLAVE_WRITE_REQUESTED'
i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
^
drivers/i2c/busses/i2c-mlxbf.c:1890:32: error: use of undeclared identifier 'I2C_SLAVE_WRITE_RECEIVED'
ret = i2c_slave_event(slave, I2C_SLAVE_WRITE_RECEIVED,
^
drivers/i2c/busses/i2c-mlxbf.c:1892:26: error: use of undeclared identifier 'I2C_SLAVE_STOP'
i2c_slave_event(slave, I2C_SLAVE_STOP, &value);
^
Fixes: b5b5b32081cd ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/i2c/busses/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index a97a9d058198..a49e0ed4a599 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -734,6 +734,7 @@ config I2C_LPC2K
config I2C_MLXBF
tristate "Mellanox BlueField I2C controller"
depends on MELLANOX_PLATFORM && ARM64
+ select I2C_SLAVE
help
Enabling this option will add I2C SMBus support for Mellanox BlueField
system.
--
2.27.0
> Subject: [PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE
>
> From: Arnd Bergmann <[email protected]>
>
> If this is not enabled, the interfaces used in this driver do not work:
>
> drivers/i2c/busses/i2c-mlxbf.c:1888:3: error: implicit declaration of function
> 'i2c_slave_event' [-Werror,-Wimplicit-function-declaration]
> i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1888:26: error: use of undeclared identifier
> 'I2C_SLAVE_WRITE_REQUESTED'
> i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1890:32: error: use of undeclared identifier
> 'I2C_SLAVE_WRITE_RECEIVED'
> ret = i2c_slave_event(slave, I2C_SLAVE_WRITE_RECEIVED,
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1892:26: error: use of undeclared identifier
> 'I2C_SLAVE_STOP'
> i2c_slave_event(slave, I2C_SLAVE_STOP, &value);
> ^
>
> Fixes: b5b5b32081cd ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField
> SoC")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/i2c/busses/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index a97a9d058198..a49e0ed4a599 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -734,6 +734,7 @@ config I2C_LPC2K
> config I2C_MLXBF
> tristate "Mellanox BlueField I2C controller"
> depends on MELLANOX_PLATFORM && ARM64
> + select I2C_SLAVE
> help
> Enabling this option will add I2C SMBus support for Mellanox BlueField
> system.
> --
> 2.27.0
Thank you!
Acked-by: Khalil Blaiech <[email protected]>
On Thu, Dec 03, 2020 at 11:32:50PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> If this is not enabled, the interfaces used in this driver do not work:
>
> drivers/i2c/busses/i2c-mlxbf.c:1888:3: error: implicit declaration of function 'i2c_slave_event' [-Werror,-Wimplicit-function-declaration]
> i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1888:26: error: use of undeclared identifier 'I2C_SLAVE_WRITE_REQUESTED'
> i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1890:32: error: use of undeclared identifier 'I2C_SLAVE_WRITE_RECEIVED'
> ret = i2c_slave_event(slave, I2C_SLAVE_WRITE_RECEIVED,
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1892:26: error: use of undeclared identifier 'I2C_SLAVE_STOP'
> i2c_slave_event(slave, I2C_SLAVE_STOP, &value);
> ^
>
> Fixes: b5b5b32081cd ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
> Signed-off-by: Arnd Bergmann <[email protected]>
Applied to for-current, thanks!