2020-12-04 08:45:03

by Zhang Changzhong

[permalink] [raw]

Subject: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint()

---

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zhang Changzhong <[email protected]>
---
drivers/vhost/scsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 6ff8a5096..4ce9f00 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
if (!vhost_vq_is_setup(vq))
continue;

- if (vhost_scsi_setup_vq_cmds(vq, vq->num))
+ ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
+ if (ret)
goto destroy_vq_cmds;
}

--
2.9.5

2020-12-04 16:15:21

by Mike Christie

[permalink] [raw]

Subject: Re: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint()

---

On 12/4/20 2:43 AM, Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zhang Changzhong <[email protected]>
> ---
> drivers/vhost/scsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 6ff8a5096..4ce9f00 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
> if (!vhost_vq_is_setup(vq))
> continue;
>
> - if (vhost_scsi_setup_vq_cmds(vq, vq->num))
> + ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
> + if (ret)
> goto destroy_vq_cmds;
> }
>
>

Reviewed-by: Mike Christie <[email protected]>

2020-12-07 05:25:30

by Jason Wang

[permalink] [raw]

Subject: Re: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint()

---

On 2020/12/4 下午4:43, Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zhang Changzhong <[email protected]>
> ---
> drivers/vhost/scsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 6ff8a5096..4ce9f00 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
> if (!vhost_vq_is_setup(vq))
> continue;
>
> - if (vhost_scsi_setup_vq_cmds(vq, vq->num))
> + ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
> + if (ret)
> goto destroy_vq_cmds;
> }
>


Acked-by: Jason Wang <[email protected]>

2020-12-07 16:12:03

by Stefan Hajnoczi

[permalink] [raw]

Subject: Re: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint()

---

On Fri, Dec 04, 2020 at 04:43:30PM +0800, Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zhang Changzhong <[email protected]>
> ---
> drivers/vhost/scsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Acked-by: Stefan Hajnoczi <[email protected]>

---

Attachments:

(No filename) (521.00 B)
signature.asc (499.00 B)
Download all attachments