Hi all,
After merging the kbuild tree, today's linux-next build (x86_64
modules_install) produced this warning:
Warning: 'make modules_install' requires depmod. Please install it.
This is probably in the kmod package.
Introduced by commit
330029209513 ("kbuild: don't hardcode depmod path")
Unfortunately for most of us (?), /sbin is not in our PATH ...
--
Cheers,
Stephen Rothwell
Stephen Rothwell wrote on Wed, Dec 09, 2020:
> After merging the kbuild tree, today's linux-next build (x86_64
> modules_install) produced this warning:
>
> Warning: 'make modules_install' requires depmod. Please install it.
> This is probably in the kmod package.
>
> Introduced by commit
>
> 330029209513 ("kbuild: don't hardcode depmod path")
>
> Unfortunately for most of us (?), /sbin is not in our PATH ...
d'oh.
Now you say this, I always found stupid distros that don't include sbin
in user PATHs: utilities like ip and a few others are perfectly useable
as reglar users to query the system state and the first thing I always
do is to add /sbin to my path on the rare distros that do this
(debian-based distros only?) so it totally slipped out of my head :/
I guess it's possible to make kbuild check both sbin and PATH, would
that be acceptable?
I'll have a look at how to do that if so.
--
Dominique
Hi Dominique,
On Wed, 9 Dec 2020 14:01:30 +0100 Dominique Martinet <[email protected]> wrote:
>
> I guess it's possible to make kbuild check both sbin and PATH, would
> that be acceptable?
I guess so. But, have you actually found any setup where depmod is not
/sbin/depmod? i.e. what problem are you trying to solve. As far as I
can see all this change does is (ever so slightly) slow down the build
for no gain.
--
Cheers,
Stephen Rothwell
Stephen Rothwell wrote on Thu, Dec 10, 2020:
> On Wed, 9 Dec 2020 14:01:30 +0100 Dominique Martinet <[email protected]> wrote:
> >
> > I guess it's possible to make kbuild check both sbin and PATH, would
> > that be acceptable?
>
> I guess so. But, have you actually found any setup where depmod is not
> /sbin/depmod? i.e. what problem are you trying to solve. As far as I
> can see all this change does is (ever so slightly) slow down the build
> for no gain.
On nixos, depmod is in /run/current-system/sw/bin/depmod (as a link to
/nix/store/r3r39rzsrikdsv68rvswn3hhank706gj-kmod-27/bin/depmod or
wherever the current version wants to be).
developers on guix probably face the same problem.
There is no sbin, the only things in /bin is sh, and in /usr/bin env as
I think is mandated by posix.
For their official builds they just modify the build scripts in place
before starting the build, but for dev as I keep rebasing it's annoying
to keep a couple of local patches just for this.
I could obviously manually create a link from /sbin/depmod to the
current system's but that doesn't solve the problem for all other nixos
users.
I'll send an updated patch later today..
--
Dominique
Hi all,
On Wed, 9 Dec 2020 20:30:29 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the kbuild tree, today's linux-next build (x86_64
> modules_install) produced this warning:
>
> Warning: 'make modules_install' requires depmod. Please install it.
> This is probably in the kmod package.
>
> Introduced by commit
>
> 330029209513 ("kbuild: don't hardcode depmod path")
>
> Unfortunately for most of us (?), /sbin is not in our PATH ...
I am still getting this warning.
--
Cheers,
Stephen Rothwell