2020-11-09 09:10:09

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH 0/8] arm/arm64: dts: Use generic "ngpios" rather than "snps,nr-gpios"

To remove similar errors as below for all snps dw gpio users:

OF: /...gpio-port@0: could not find phandle

Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.

Jisheng Zhang (8):
arm64: dts: socfpga: Use generic "ngpios" rather than "snps,nr-gpios"
arm64: dts: apm: Use generic "ngpios" rather than "snps,nr-gpios"
arm64: dts: bitmain: Use generic "ngpios" rather than "snps,nr-gpios"
arm64: dts: hisilicon: Use generic "ngpios" rather than
"snps,nr-gpios"
arm64: dts: agilex: Use generic "ngpios" rather than "snps,nr-gpios"
arm64: dts: synaptics: Use generic "ngpios" rather than
"snps,nr-gpios"
ARM: dts: berlin: Use generic "ngpios" rather than "snps,nr-gpios"
ARM: dts: socfgpa: Use generic "ngpios" rather than "snps,nr-gpios"

arch/arm/boot/dts/berlin2.dtsi | 12 ++++++------
arch/arm/boot/dts/berlin2cd.dtsi | 12 ++++++------
arch/arm/boot/dts/berlin2q.dtsi | 12 ++++++------
arch/arm/boot/dts/socfpga.dtsi | 6 +++---
arch/arm/boot/dts/socfpga_arria10.dtsi | 6 +++---
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 4 ++--
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 2 +-
arch/arm64/boot/dts/apm/apm-storm.dtsi | 2 +-
arch/arm64/boot/dts/bitmain/bm1880.dtsi | 6 +++---
arch/arm64/boot/dts/hisilicon/hip05.dtsi | 4 ++--
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++--
arch/arm64/boot/dts/synaptics/as370.dtsi | 4 ++--
arch/arm64/boot/dts/synaptics/berlin4ct.dtsi | 12 ++++++------
13 files changed, 43 insertions(+), 43 deletions(-)

--
2.29.2


2020-11-09 09:10:09

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH 6/8] arm64: dts: synaptics: Use generic "ngpios" rather than "snps,nr-gpios"

This is to remove similar errors as below:

OF: /.../gpio-port@0: could not find phandle

Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.

Signed-off-by: Jisheng Zhang <[email protected]>
---
arch/arm64/boot/dts/synaptics/as370.dtsi | 4 ++--
arch/arm64/boot/dts/synaptics/berlin4ct.dtsi | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/synaptics/as370.dtsi b/arch/arm64/boot/dts/synaptics/as370.dtsi
index addeb0efc616..4bb5d650df9c 100644
--- a/arch/arm64/boot/dts/synaptics/as370.dtsi
+++ b/arch/arm64/boot/dts/synaptics/as370.dtsi
@@ -143,7 +143,7 @@ porta: gpio-port@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -161,7 +161,7 @@ portb: gpio-port@1 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
diff --git a/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi b/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi
index 15625b99e336..0949acee4728 100644
--- a/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi
+++ b/arch/arm64/boot/dts/synaptics/berlin4ct.dtsi
@@ -140,7 +140,7 @@ porta: gpio-port@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -158,7 +158,7 @@ portb: gpio-port@1 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -176,7 +176,7 @@ portc: gpio-port@2 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -194,7 +194,7 @@ portd: gpio-port@3 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -269,7 +269,7 @@ porte: gpio-port@4 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
};
};
@@ -284,7 +284,7 @@ portf: gpio-port@5 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
};
};
--
2.29.2

2020-11-09 09:10:09

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH 3/8] arm64: dts: bitmain: Use generic "ngpios" rather than "snps,nr-gpios"

This is to remove similar errors as below:

OF: /.../gpio-port@0: could not find phandle

Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.

Signed-off-by: Jisheng Zhang <[email protected]>
---
arch/arm64/boot/dts/bitmain/bm1880.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/bitmain/bm1880.dtsi b/arch/arm64/boot/dts/bitmain/bm1880.dtsi
index fa6e6905f588..53a9b76057aa 100644
--- a/arch/arm64/boot/dts/bitmain/bm1880.dtsi
+++ b/arch/arm64/boot/dts/bitmain/bm1880.dtsi
@@ -127,7 +127,7 @@ porta: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -145,7 +145,7 @@ portb: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -163,7 +163,7 @@ portc: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
--
2.29.2

2020-11-09 09:10:12

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH 5/8] arm64: dts: agilex: Use generic "ngpios" rather than "snps,nr-gpios"

This is to remove similar errors as below:

OF: /.../gpio-port@0: could not find phandle

Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.

Signed-off-by: Jisheng Zhang <[email protected]>
---
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index e1c0fcba5c20..2f731e3a7cd7 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -202,7 +202,7 @@ porta: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <24>;
+ ngpios = <24>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -222,7 +222,7 @@ portb: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <24>;
+ ngpios = <24>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
--
2.29.2

2020-11-09 09:11:22

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH 8/8] ARM: dts: socfgpa: Use generic "ngpios" rather than "snps,nr-gpios"

This is to remove similar errors as below:

OF: /.../gpio-port@0: could not find phandle

Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.

Signed-off-by: Jisheng Zhang <[email protected]>
---
arch/arm/boot/dts/socfpga.dtsi | 6 +++---
arch/arm/boot/dts/socfpga_arria10.dtsi | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 0b021eef0b53..32b7ad814ec6 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -612,7 +612,7 @@ porta: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <29>;
+ ngpios = <29>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -633,7 +633,7 @@ portb: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <29>;
+ ngpios = <29>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -654,7 +654,7 @@ portc: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <27>;
+ ngpios = <27>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi
index 0013ec3463c4..34e23e0582fb 100644
--- a/arch/arm/boot/dts/socfpga_arria10.dtsi
+++ b/arch/arm/boot/dts/socfpga_arria10.dtsi
@@ -491,7 +491,7 @@ porta: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <29>;
+ ngpios = <29>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -511,7 +511,7 @@ portb: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <29>;
+ ngpios = <29>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -531,7 +531,7 @@ portc: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <27>;
+ ngpios = <27>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
--
2.29.2

2020-11-09 09:11:31

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH 1/8] arm64: dts: socfpga: Use generic "ngpios" rather than "snps,nr-gpios"

This is to remove similar errors as below:

OF: /.../gpio-port@0: could not find phandle

Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.

Signed-off-by: Jisheng Zhang <[email protected]>
---
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
index 0f893984c256..d301ac0d406b 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
@@ -203,7 +203,7 @@ porta: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <24>;
+ ngpios = <24>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -223,7 +223,7 @@ portb: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <24>;
+ ngpios = <24>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
--
2.29.2

2020-11-09 09:12:50

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH 4/8] arm64: dts: hisilicon: Use generic "ngpios" rather than "snps,nr-gpios"

This is to remove similar errors as below:

OF: /.../gpio-port@0: could not find phandle

Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.

Signed-off-by: Jisheng Zhang <[email protected]>
---
arch/arm64/boot/dts/hisilicon/hip05.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/hisilicon/hip05.dtsi b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
index bc49955360db..fbe83eb9f77b 100644
--- a/arch/arm64/boot/dts/hisilicon/hip05.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
@@ -335,7 +335,7 @@ porta: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -354,7 +354,7 @@ portb: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
--
2.29.2

2020-11-09 09:13:29

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH 7/8] ARM: dts: berlin: Use generic "ngpios" rather than "snps,nr-gpios"

This is to remove similar errors as below:

OF: /.../gpio-port@0: could not find phandle

Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
explained the reason of above errors well and added the generic
"ngpios" property, let's use it.

Signed-off-by: Jisheng Zhang <[email protected]>
---
arch/arm/boot/dts/berlin2.dtsi | 12 ++++++------
arch/arm/boot/dts/berlin2cd.dtsi | 12 ++++++------
arch/arm/boot/dts/berlin2q.dtsi | 12 ++++++------
3 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi
index 6194857f8a02..1114c592e461 100644
--- a/arch/arm/boot/dts/berlin2.dtsi
+++ b/arch/arm/boot/dts/berlin2.dtsi
@@ -191,7 +191,7 @@ porta: gpio-port@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -209,7 +209,7 @@ portb: gpio-port@1 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -227,7 +227,7 @@ portc: gpio-port@2 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -245,7 +245,7 @@ portd: gpio-port@3 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -446,7 +446,7 @@ portf: gpio-port@5 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
};
};
@@ -461,7 +461,7 @@ porte: gpio-port@4 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
diff --git a/arch/arm/boot/dts/berlin2cd.dtsi b/arch/arm/boot/dts/berlin2cd.dtsi
index 6f30d7eb3b41..b2768f7a3185 100644
--- a/arch/arm/boot/dts/berlin2cd.dtsi
+++ b/arch/arm/boot/dts/berlin2cd.dtsi
@@ -181,7 +181,7 @@ porta: gpio-port@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -199,7 +199,7 @@ portb: gpio-port@1 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -217,7 +217,7 @@ portc: gpio-port@2 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -235,7 +235,7 @@ portd: gpio-port@3 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -473,7 +473,7 @@ portf: gpio-port@5 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
};
};
@@ -518,7 +518,7 @@ porte: gpio-port@4 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <8>;
+ ngpios = <8>;
reg = <0>;
};
};
diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index b6a0acac6836..598a46f96a82 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -252,7 +252,7 @@ porta: gpio-port@0 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -270,7 +270,7 @@ portb: gpio-port@1 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -288,7 +288,7 @@ portc: gpio-port@2 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -306,7 +306,7 @@ portd: gpio-port@3 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
@@ -552,7 +552,7 @@ portf: gpio-port@5 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
};
};
@@ -613,7 +613,7 @@ porte: gpio-port@4 {
compatible = "snps,dw-apb-gpio-port";
gpio-controller;
#gpio-cells = <2>;
- snps,nr-gpios = <32>;
+ ngpios = <32>;
reg = <0>;
};
};
--
2.29.2

2020-11-10 14:46:34

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 0/8] arm/arm64: dts: Use generic "ngpios" rather than "snps,nr-gpios"

On Mon, Nov 9, 2020 at 10:07 AM Jisheng Zhang
<[email protected]> wrote:

> To remove similar errors as below for all snps dw gpio users:
>
> OF: /...gpio-port@0: could not find phandle
>
> Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> explained the reason of above errors well and added the generic
> "ngpios" property, let's use it.

Reviewed-by: Linus Walleij <[email protected]>
For all 8 patches.

Thanks for cleaning this up!

Yours,
Linus Walleij

2020-11-13 13:50:12

by Dinh Nguyen

[permalink] [raw]
Subject: Re: [PATCH 1/8] arm64: dts: socfpga: Use generic "ngpios" rather than "snps,nr-gpios"



On 11/9/20 3:03 AM, Jisheng Zhang wrote:
> This is to remove similar errors as below:
>
> OF: /.../gpio-port@0: could not find phandle
>
> Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> explained the reason of above errors well and added the generic
> "ngpios" property, let's use it.
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---
> arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> index 0f893984c256..d301ac0d406b 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> @@ -203,7 +203,7 @@ porta: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <24>;
> + ngpios = <24>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -223,7 +223,7 @@ portb: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <24>;
> + ngpios = <24>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
>

Acked-by: Dinh Nguyen <[email protected]>

2020-11-13 13:51:03

by Dinh Nguyen

[permalink] [raw]
Subject: Re: [PATCH 5/8] arm64: dts: agilex: Use generic "ngpios" rather than "snps,nr-gpios"



On 11/9/20 3:05 AM, Jisheng Zhang wrote:
> This is to remove similar errors as below:
>
> OF: /.../gpio-port@0: could not find phandle
>
> Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> explained the reason of above errors well and added the generic
> "ngpios" property, let's use it.
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---
> arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> index e1c0fcba5c20..2f731e3a7cd7 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> @@ -202,7 +202,7 @@ porta: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <24>;
> + ngpios = <24>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -222,7 +222,7 @@ portb: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <24>;
> + ngpios = <24>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
>

Acked-by: Dinh Nguyen <[email protected]>

2020-11-13 13:51:11

by Dinh Nguyen

[permalink] [raw]
Subject: Re: [PATCH 5/8] arm64: dts: agilex: Use generic "ngpios" rather than "snps,nr-gpios"



On 11/9/20 3:05 AM, Jisheng Zhang wrote:
> This is to remove similar errors as below:
>
> OF: /.../gpio-port@0: could not find phandle
>
> Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> explained the reason of above errors well and added the generic
> "ngpios" property, let's use it.
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---
> arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> index e1c0fcba5c20..2f731e3a7cd7 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> @@ -202,7 +202,7 @@ porta: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <24>;
> + ngpios = <24>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -222,7 +222,7 @@ portb: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <24>;
> + ngpios = <24>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
>

Acked-by: Dinh Nguyen <[email protected]>

2020-11-13 13:51:54

by Dinh Nguyen

[permalink] [raw]
Subject: Re: [PATCH 8/8] ARM: dts: socfgpa: Use generic "ngpios" rather than "snps,nr-gpios"



On 11/9/20 3:07 AM, Jisheng Zhang wrote:
> This is to remove similar errors as below:
>
> OF: /.../gpio-port@0: could not find phandle
>
> Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> explained the reason of above errors well and added the generic
> "ngpios" property, let's use it.
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---
> arch/arm/boot/dts/socfpga.dtsi | 6 +++---
> arch/arm/boot/dts/socfpga_arria10.dtsi | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 0b021eef0b53..32b7ad814ec6 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -612,7 +612,7 @@ porta: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <29>;
> + ngpios = <29>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -633,7 +633,7 @@ portb: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <29>;
> + ngpios = <29>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -654,7 +654,7 @@ portc: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <27>;
> + ngpios = <27>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi
> index 0013ec3463c4..34e23e0582fb 100644
> --- a/arch/arm/boot/dts/socfpga_arria10.dtsi
> +++ b/arch/arm/boot/dts/socfpga_arria10.dtsi
> @@ -491,7 +491,7 @@ porta: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <29>;
> + ngpios = <29>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -511,7 +511,7 @@ portb: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <29>;
> + ngpios = <29>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -531,7 +531,7 @@ portc: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <27>;
> + ngpios = <27>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
>

Acked-by: Dinh Nguyen <[email protected]>

2020-11-16 05:38:13

by Manivannan Sadhasivam

[permalink] [raw]
Subject: Re: [PATCH 3/8] arm64: dts: bitmain: Use generic "ngpios" rather than "snps,nr-gpios"

On Mon, Nov 09, 2020 at 05:04:31PM +0800, Jisheng Zhang wrote:
> This is to remove similar errors as below:
>
> OF: /.../gpio-port@0: could not find phandle
>
> Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> explained the reason of above errors well and added the generic
> "ngpios" property, let's use it.
>
> Signed-off-by: Jisheng Zhang <[email protected]>

Acked-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
> arch/arm64/boot/dts/bitmain/bm1880.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/bitmain/bm1880.dtsi b/arch/arm64/boot/dts/bitmain/bm1880.dtsi
> index fa6e6905f588..53a9b76057aa 100644
> --- a/arch/arm64/boot/dts/bitmain/bm1880.dtsi
> +++ b/arch/arm64/boot/dts/bitmain/bm1880.dtsi
> @@ -127,7 +127,7 @@ porta: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <32>;
> + ngpios = <32>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -145,7 +145,7 @@ portb: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <32>;
> + ngpios = <32>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -163,7 +163,7 @@ portc: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <8>;
> + ngpios = <8>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> --
> 2.29.2
>

2020-11-25 02:33:05

by Wei Xu

[permalink] [raw]
Subject: Re: [PATCH 4/8] arm64: dts: hisilicon: Use generic "ngpios" rather than "snps,nr-gpios"

Hi Jisheng,

On 2020/11/9 17:05, Jisheng Zhang wrote:
> This is to remove similar errors as below:
>
> OF: /.../gpio-port@0: could not find phandle
>
> Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> explained the reason of above errors well and added the generic
> "ngpios" property, let's use it.
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---
> arch/arm64/boot/dts/hisilicon/hip05.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hip05.dtsi b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
> index bc49955360db..fbe83eb9f77b 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip05.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hip05.dtsi
> @@ -335,7 +335,7 @@ porta: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <32>;
> + ngpios = <32>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -354,7 +354,7 @@ portb: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <32>;
> + ngpios = <32>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
>

Thanks!
Applied to the hisilicon arm64 dt tree.

Best Regards,
Wei

2020-12-10 09:18:21

by Jisheng Zhang

[permalink] [raw]
Subject: Re: [PATCH 0/8] arm/arm64: dts: Use generic "ngpios" rather than "snps,nr-gpios"

On Tue, 10 Nov 2020 15:43:36 +0100 Linus Walleij <[email protected]> wrote:


>
>
> On Mon, Nov 9, 2020 at 10:07 AM Jisheng Zhang
> <[email protected]> wrote:
>
> > To remove similar errors as below for all snps dw gpio users:
> >
> > OF: /...gpio-port@0: could not find phandle
> >
> > Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> > explained the reason of above errors well and added the generic
> > "ngpios" property, let's use it.
>
> Reviewed-by: Linus Walleij <[email protected]>
> For all 8 patches.

> Thanks for cleaning this up!
>
> Yours,
> Linus Walleij

Hi all,

I merged patch6 and patch7 to berlin, will send out a berlin SoC dts
Pull-Request today.

For other patches, I see Wei has taken patch4, will other patches be
taken by each SoC maintainers?

thanks

2020-12-10 09:36:57

by Manivannan Sadhasivam

[permalink] [raw]
Subject: Re: [PATCH 0/8] arm/arm64: dts: Use generic "ngpios" rather than "snps,nr-gpios"

On Thu, Dec 10, 2020 at 05:12:24PM +0800, Jisheng Zhang wrote:
> On Tue, 10 Nov 2020 15:43:36 +0100 Linus Walleij <[email protected]> wrote:
>
>
> >
> >
> > On Mon, Nov 9, 2020 at 10:07 AM Jisheng Zhang
> > <[email protected]> wrote:
> >
> > > To remove similar errors as below for all snps dw gpio users:
> > >
> > > OF: /...gpio-port@0: could not find phandle
> > >
> > > Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> > > explained the reason of above errors well and added the generic
> > > "ngpios" property, let's use it.
> >
> > Reviewed-by: Linus Walleij <[email protected]>
> > For all 8 patches.
>
> > Thanks for cleaning this up!
> >
> > Yours,
> > Linus Walleij
>
> Hi all,
>
> I merged patch6 and patch7 to berlin, will send out a berlin SoC dts
> Pull-Request today.
>
> For other patches, I see Wei has taken patch4, will other patches be
> taken by each SoC maintainers?

For bitmain platform, I don't have any other patches this cylce. So I'll
just send this patch directly to [email protected].

Thanks,
Mani

>
> thanks

2021-01-04 21:22:09

by Dinh Nguyen

[permalink] [raw]
Subject: Re: [PATCH 8/8] ARM: dts: socfgpa: Use generic "ngpios" rather than "snps,nr-gpios"



On 11/9/20 3:07 AM, Jisheng Zhang wrote:
> This is to remove similar errors as below:
>
> OF: /.../gpio-port@0: could not find phandle
>
> Commit 7569486d79ae ("gpio: dwapb: Add ngpios DT-property support")
> explained the reason of above errors well and added the generic
> "ngpios" property, let's use it.
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---
> arch/arm/boot/dts/socfpga.dtsi | 6 +++---
> arch/arm/boot/dts/socfpga_arria10.dtsi | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 0b021eef0b53..32b7ad814ec6 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -612,7 +612,7 @@ porta: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <29>;
> + ngpios = <29>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -633,7 +633,7 @@ portb: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <29>;
> + ngpios = <29>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -654,7 +654,7 @@ portc: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <27>;
> + ngpios = <27>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi
> index 0013ec3463c4..34e23e0582fb 100644
> --- a/arch/arm/boot/dts/socfpga_arria10.dtsi
> +++ b/arch/arm/boot/dts/socfpga_arria10.dtsi
> @@ -491,7 +491,7 @@ porta: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <29>;
> + ngpios = <29>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -511,7 +511,7 @@ portb: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <29>;
> + ngpios = <29>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -531,7 +531,7 @@ portc: gpio-controller@0 {
> compatible = "snps,dw-apb-gpio-port";
> gpio-controller;
> #gpio-cells = <2>;
> - snps,nr-gpios = <27>;
> + ngpios = <27>;
> reg = <0>;
> interrupt-controller;
> #interrupt-cells = <2>;
>

Applied to socfpga dts tree.

Thanks,
Dinh