2020-12-10 19:52:21

by Thomas Gleixner

Subject: [patch 17/30] NTB/msi: Use irq_has_action()

Use the proper core function.

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Jon Mason <[email protected]>
Cc: Dave Jiang <[email protected]>
Cc: Allen Hubbe <[email protected]>
Cc: [email protected]
---
drivers/ntb/msi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/ntb/msi.c
+++ b/drivers/ntb/msi.c
@@ -282,15 +282,13 @@ int ntbm_msi_request_threaded_irq(struct
struct ntb_msi_desc *msi_desc)
{
struct msi_desc *entry;
- struct irq_desc *desc;
int ret;

if (!ntb->msi)
return -EINVAL;

for_each_pci_msi_entry(entry, ntb->pdev) {
- desc = irq_to_desc(entry->irq);
- if (desc->action)
+ if (irq_has_action(entry->irq))
continue;

ret = devm_request_threaded_irq(&ntb->dev, entry->irq, handler,

2020-12-10 20:42:21

by Logan Gunthorpe

Subject: Re: [patch 17/30] NTB/msi: Use irq_has_action()

On 2020-12-10 12:25 p.m., Thomas Gleixner wrote:
> Use the proper core function.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Jon Mason <[email protected]>
> Cc: Dave Jiang <[email protected]>
> Cc: Allen Hubbe <[email protected]>
> Cc: [email protected]

Looks good to me.

Reviewed-by: Logan Gunthorpe <[email protected]>

> ---
> drivers/ntb/msi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> --- a/drivers/ntb/msi.c
> +++ b/drivers/ntb/msi.c
> @@ -282,15 +282,13 @@ int ntbm_msi_request_threaded_irq(struct
> struct ntb_msi_desc *msi_desc)
> {
> struct msi_desc *entry;
> - struct irq_desc *desc;
> int ret;
>
> if (!ntb->msi)
> return -EINVAL;
>
> for_each_pci_msi_entry(entry, ntb->pdev) {
> - desc = irq_to_desc(entry->irq);
> - if (desc->action)
> + if (irq_has_action(entry->irq))
> continue;
>
> ret = devm_request_threaded_irq(&ntb->dev, entry->irq, handler,
>

2020-12-13 15:14:08

by tip-bot2 for Alexey Makhalov

Subject: [tip: irq/core] NTB/msi: Use irq_has_action()

The following commit has been merged into the irq/core branch of tip:

Commit-ID: d53c576bd3d4787b3d7d0d814b28ae67099d84a1
Gitweb: https://git.kernel.org/tip/d53c576bd3d4787b3d7d0d814b28ae67099d84a1
Author: Thomas Gleixner <[email protected]>
AuthorDate: Thu, 10 Dec 2020 20:25:53 +01:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Sat, 12 Dec 2020 12:59:05 +01:00

NTB/msi: Use irq_has_action()

Use the proper core function.

Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Logan Gunthorpe <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

---
drivers/ntb/msi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/ntb/msi.c b/drivers/ntb/msi.c
index 0a5e884..3f05cfb 100644
--- a/drivers/ntb/msi.c
+++ b/drivers/ntb/msi.c
@@ -282,15 +282,13 @@ int ntbm_msi_request_threaded_irq(struct ntb_dev *ntb, irq_handler_t handler,
struct ntb_msi_desc *msi_desc)
{
struct msi_desc *entry;
- struct irq_desc *desc;
int ret;

if (!ntb->msi)
return -EINVAL;

for_each_pci_msi_entry(entry, ntb->pdev) {
- desc = irq_to_desc(entry->irq);
- if (desc->action)
+ if (irq_has_action(entry->irq))
continue;

ret = devm_request_threaded_irq(&ntb->dev, entry->irq, handler,