2020-12-11 16:56:08

by Zheng Yongjun

Subject: [PATCH -next] md/bcache: convert comma to semicolon

Replace a comma between expression statements by a semicolon.

Signed-off-by: Zheng Yongjun <[email protected]>
---
drivers/md/bcache/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index 554e3afc9b68..00a520c03f41 100644
--- a/drivers/md/bcache/sysfs.c
+++ b/drivers/md/bcache/sysfs.c
@@ -404,7 +404,7 @@ STORE(__cached_dev)
if (!env)
return -ENOMEM;
add_uevent_var(env, "DRIVER=bcache");
- add_uevent_var(env, "CACHED_UUID=%pU", dc->sb.uuid),
+ add_uevent_var(env, "CACHED_UUID=%pU", dc->sb.uuid);
add_uevent_var(env, "CACHED_LABEL=%s", buf);
kobject_uevent_env(&disk_to_dev(dc->disk.disk)->kobj,
KOBJ_CHANGE,
--
2.22.0

2020-12-14 10:01:02

by Coly Li

Subject: Re: [PATCH -next] md/bcache: convert comma to semicolon

On 12/11/20 4:52 PM, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun <[email protected]>

Thanks for the catch. Added in my 2nd wave series.

Coly Li

> ---
> drivers/md/bcache/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
> index 554e3afc9b68..00a520c03f41 100644
> --- a/drivers/md/bcache/sysfs.c
> +++ b/drivers/md/bcache/sysfs.c
> @@ -404,7 +404,7 @@ STORE(__cached_dev)
> if (!env)
> return -ENOMEM;
> add_uevent_var(env, "DRIVER=bcache");
> - add_uevent_var(env, "CACHED_UUID=%pU", dc->sb.uuid),
> + add_uevent_var(env, "CACHED_UUID=%pU", dc->sb.uuid);
> add_uevent_var(env, "CACHED_LABEL=%s", buf);
> kobject_uevent_env(&disk_to_dev(dc->disk.disk)->kobj,
> KOBJ_CHANGE,
>