2020-12-14 12:33:42

by Bongsu Jeon

Subject: [PATCH net-next] nfc: s3fwrn5: Remove the delay for nfc sleep

From: Bongsu Jeon <[email protected]>

remove the delay for nfc sleep because nfc doesn't need the sleep delay.

Signed-off-by: Bongsu Jeon <[email protected]>
---
drivers/nfc/s3fwrn5/phy_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nfc/s3fwrn5/phy_common.c b/drivers/nfc/s3fwrn5/phy_common.c
index 497b02b30ae7..81318478d5fd 100644
--- a/drivers/nfc/s3fwrn5/phy_common.c
+++ b/drivers/nfc/s3fwrn5/phy_common.c
@@ -20,7 +20,8 @@ void s3fwrn5_phy_set_wake(void *phy_id, bool wake)

mutex_lock(&phy->mutex);
gpio_set_value(phy->gpio_fw_wake, wake);
- msleep(S3FWRN5_EN_WAIT_TIME);
+ if (wake)
+ msleep(S3FWRN5_EN_WAIT_TIME);
mutex_unlock(&phy->mutex);
}
EXPORT_SYMBOL(s3fwrn5_phy_set_wake);
--
2.17.1

2020-12-14 15:56:16

by Krzysztof Kozlowski

Subject: Re: [PATCH net-next] nfc: s3fwrn5: Remove the delay for nfc sleep

On Sun, Dec 13, 2020 at 07:12:38PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon <[email protected]>
>
> remove the delay for nfc sleep because nfc doesn't need the sleep delay.

Please start sentences with capital letter.
s/nfc/NFC/ (here and in subject)

This explanation is very vague. Please rephrase it.

Best regards,
Krzysztof