2020-12-13 19:07:11

by Adam Ford

Subject: [PATCH 10/18] arm64: dts: renesas: Don't make vccq_sdhi0 always on

vccq_sdhi0 is referenced from sdhi0, so there is no need to force
this regualtor to be always-on. In theory it could help with
low power modes in the future.

Signed-off-by: Adam Ford <[email protected]>
---
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
index 87a0f556cd2f..f951bae2a1c6 100644
--- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
+++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
@@ -201,15 +201,12 @@ sound_card {

vccq_sdhi0: regulator-vccq-sdhi0 {
compatible = "regulator-gpio";
-
regulator-name = "SDHI0 VccQ";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
-
gpios = <&gpio6 30 GPIO_ACTIVE_HIGH>;
gpios-states = <1>;
states = <3300000 1>, <1800000 0>;
- regulator-always-on;
};

/* External DU dot clocks */
--
2.25.1

2020-12-17 11:28:24

by Geert Uytterhoeven

Subject: Re: [PATCH 10/18] arm64: dts: renesas: Don't make vccq_sdhi0 always on

On Sun, Dec 13, 2020 at 7:38 PM Adam Ford <[email protected]> wrote:
> vccq_sdhi0 is referenced from sdhi0, so there is no need to force
> this regualtor to be always-on. In theory it could help with

regulator

> low power modes in the future.
>
> Signed-off-by: Adam Ford <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-devel for v5.12 (with the typo fixed, and "beacon"
added to the one-line summary).

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds