2020-12-14 14:49:29

by Ionela Voinescu

[permalink] [raw]
Subject: [PATCH v2 0/4] cppc_cpufreq: fix, clarify and improve support

Hi guys,

I'm sending v2 of some of the patches at [1] in light of the discussions
at [2].

v2:
- Patches 1-3 are trivial rebase on linux next 20201211, with conflicts
fixed after eliminating what previously was "[PATCH 4/8] cppc_cpufreq:
replace per-cpu structures with lists." Therefore, I have kept
Viresh's acks.

- Patch 4 is a merge between:
- [PATCH 4/8] cppc_cpufreq: replace per-cpu structures with lists
- [PATCH] cppc_cpufreq: optimise memory allocation for HW and NONE
coordination
both found at [1].

This functionality was introducing the problem at [2] and it's fixed
in this version by bailing out of driver registration if a _CPC entry
is not found for a CPU.

Yousaf, it would be great if you can test this and make sure it
matches your expectations.

Rafael, Viresh if you think this last patch introduces too many
changes, you can skip it for 5.11 which is around the corner and
have more time for review for 5.12. I've added more eyes in the review
list.


All patches are based on linux next 20201211 after patch at [3] is
applied.

[1] https://lore.kernel.org/linux-pm/[email protected]/#t
[2] https://lore.kernel.org/linux-pm/[email protected]/
[3] https://lore.kernel.org/linux-pm/[email protected]/

Ionela Voinescu (4):
cppc_cpufreq: use policy->cpu as driver of frequency setting
cppc_cpufreq: clarify support for coordination types
cppc_cpufreq: expose information on frequency domains
cppc_cpufreq: replace per-cpu data array with a list

.../ABI/testing/sysfs-devices-system-cpu | 3 +-
drivers/acpi/cppc_acpi.c | 141 ++++++------
drivers/cpufreq/cppc_cpufreq.c | 204 ++++++++++--------
include/acpi/cppc_acpi.h | 6 +-
4 files changed, 181 insertions(+), 173 deletions(-)

--
2.29.2.dirty


2020-12-14 16:16:35

by Yousaf Kaukab

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] cppc_cpufreq: fix, clarify and improve support

On Mon, Dec 14, 2020 at 12:38:19PM +0000, Ionela Voinescu wrote:
> Hi guys,
>
> I'm sending v2 of some of the patches at [1] in light of the discussions
> at [2].
>
> v2:
> - Patches 1-3 are trivial rebase on linux next 20201211, with conflicts
> fixed after eliminating what previously was "[PATCH 4/8] cppc_cpufreq:
> replace per-cpu structures with lists." Therefore, I have kept
> Viresh's acks.
>
> - Patch 4 is a merge between:
> - [PATCH 4/8] cppc_cpufreq: replace per-cpu structures with lists
> - [PATCH] cppc_cpufreq: optimise memory allocation for HW and NONE
> coordination
> both found at [1].
>
> This functionality was introducing the problem at [2] and it's fixed
> in this version by bailing out of driver registration if a _CPC entry
> is not found for a CPU.
>
> Yousaf, it would be great if you can test this and make sure it
> matches your expectations.
>
> Rafael, Viresh if you think this last patch introduces too many
> changes, you can skip it for 5.11 which is around the corner and
> have more time for review for 5.12. I've added more eyes in the review
> list.
>
>
> All patches are based on linux next 20201211 after patch at [3] is
> applied.
>
> [1] https://lore.kernel.org/linux-pm/[email protected]/#t
> [2] https://lore.kernel.org/linux-pm/[email protected]/
> [3] https://lore.kernel.org/linux-pm/[email protected]/
>
> Ionela Voinescu (4):
> cppc_cpufreq: use policy->cpu as driver of frequency setting
> cppc_cpufreq: clarify support for coordination types
> cppc_cpufreq: expose information on frequency domains
> cppc_cpufreq: replace per-cpu data array with a list
>
> .../ABI/testing/sysfs-devices-system-cpu | 3 +-
> drivers/acpi/cppc_acpi.c | 141 ++++++------
> drivers/cpufreq/cppc_cpufreq.c | 204 ++++++++++--------
> include/acpi/cppc_acpi.h | 6 +-
> 4 files changed, 181 insertions(+), 173 deletions(-)

For the whole series:
Tested-by: Mian Yousaf Kaukab <[email protected]>

2020-12-15 18:24:11

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] cppc_cpufreq: fix, clarify and improve support

On Mon, Dec 14, 2020 at 5:14 PM Mian Yousaf Kaukab <[email protected]> wrote:
>
> On Mon, Dec 14, 2020 at 12:38:19PM +0000, Ionela Voinescu wrote:
> > Hi guys,
> >
> > I'm sending v2 of some of the patches at [1] in light of the discussions
> > at [2].
> >
> > v2:
> > - Patches 1-3 are trivial rebase on linux next 20201211, with conflicts
> > fixed after eliminating what previously was "[PATCH 4/8] cppc_cpufreq:
> > replace per-cpu structures with lists." Therefore, I have kept
> > Viresh's acks.
> >
> > - Patch 4 is a merge between:
> > - [PATCH 4/8] cppc_cpufreq: replace per-cpu structures with lists
> > - [PATCH] cppc_cpufreq: optimise memory allocation for HW and NONE
> > coordination
> > both found at [1].
> >
> > This functionality was introducing the problem at [2] and it's fixed
> > in this version by bailing out of driver registration if a _CPC entry
> > is not found for a CPU.
> >
> > Yousaf, it would be great if you can test this and make sure it
> > matches your expectations.
> >
> > Rafael, Viresh if you think this last patch introduces too many
> > changes, you can skip it for 5.11 which is around the corner and
> > have more time for review for 5.12. I've added more eyes in the review
> > list.
> >
> >
> > All patches are based on linux next 20201211 after patch at [3] is
> > applied.
> >
> > [1] https://lore.kernel.org/linux-pm/[email protected]/#t
> > [2] https://lore.kernel.org/linux-pm/[email protected]/
> > [3] https://lore.kernel.org/linux-pm/[email protected]/
> >
> > Ionela Voinescu (4):
> > cppc_cpufreq: use policy->cpu as driver of frequency setting
> > cppc_cpufreq: clarify support for coordination types
> > cppc_cpufreq: expose information on frequency domains
> > cppc_cpufreq: replace per-cpu data array with a list
> >
> > .../ABI/testing/sysfs-devices-system-cpu | 3 +-
> > drivers/acpi/cppc_acpi.c | 141 ++++++------
> > drivers/cpufreq/cppc_cpufreq.c | 204 ++++++++++--------
> > include/acpi/cppc_acpi.h | 6 +-
> > 4 files changed, 181 insertions(+), 173 deletions(-)
>
> For the whole series:
> Tested-by: Mian Yousaf Kaukab <[email protected]>

All patches applied as 5.11-rc material, thanks!

2020-12-16 00:05:53

by Ionela Voinescu

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] cppc_cpufreq: fix, clarify and improve support

On Tuesday 15 Dec 2020 at 19:21:01 (+0100), Rafael J. Wysocki wrote:
> On Mon, Dec 14, 2020 at 5:14 PM Mian Yousaf Kaukab <[email protected]> wrote:
> >
> > On Mon, Dec 14, 2020 at 12:38:19PM +0000, Ionela Voinescu wrote:
> > > Hi guys,
> > >
> > > I'm sending v2 of some of the patches at [1] in light of the discussions
> > > at [2].
> > >
> > > v2:
> > > - Patches 1-3 are trivial rebase on linux next 20201211, with conflicts
> > > fixed after eliminating what previously was "[PATCH 4/8] cppc_cpufreq:
> > > replace per-cpu structures with lists." Therefore, I have kept
> > > Viresh's acks.
> > >
> > > - Patch 4 is a merge between:
> > > - [PATCH 4/8] cppc_cpufreq: replace per-cpu structures with lists
> > > - [PATCH] cppc_cpufreq: optimise memory allocation for HW and NONE
> > > coordination
> > > both found at [1].
> > >
> > > This functionality was introducing the problem at [2] and it's fixed
> > > in this version by bailing out of driver registration if a _CPC entry
> > > is not found for a CPU.
> > >
> > > Yousaf, it would be great if you can test this and make sure it
> > > matches your expectations.
> > >
> > > Rafael, Viresh if you think this last patch introduces too many
> > > changes, you can skip it for 5.11 which is around the corner and
> > > have more time for review for 5.12. I've added more eyes in the review
> > > list.
> > >
> > >
> > > All patches are based on linux next 20201211 after patch at [3] is
> > > applied.
> > >
> > > [1] https://lore.kernel.org/linux-pm/[email protected]/#t
> > > [2] https://lore.kernel.org/linux-pm/[email protected]/
> > > [3] https://lore.kernel.org/linux-pm/[email protected]/
> > >
> > > Ionela Voinescu (4):
> > > cppc_cpufreq: use policy->cpu as driver of frequency setting
> > > cppc_cpufreq: clarify support for coordination types
> > > cppc_cpufreq: expose information on frequency domains
> > > cppc_cpufreq: replace per-cpu data array with a list
> > >
> > > .../ABI/testing/sysfs-devices-system-cpu | 3 +-
> > > drivers/acpi/cppc_acpi.c | 141 ++++++------
> > > drivers/cpufreq/cppc_cpufreq.c | 204 ++++++++++--------
> > > include/acpi/cppc_acpi.h | 6 +-
> > > 4 files changed, 181 insertions(+), 173 deletions(-)
> >
> > For the whole series:
> > Tested-by: Mian Yousaf Kaukab <[email protected]>
>
> All patches applied as 5.11-rc material, thanks!

Many thanks, guys!

Ionela.