2020-12-11 16:58:00

by Zheng Yongjun

Subject: [PATCH -next] usb: phy: convert comma to semicolon

Replace a comma between expression statements by a semicolon.

Signed-off-by: Zheng Yongjun <[email protected]>
---
drivers/usb/phy/phy-isp1301-omap.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/phy/phy-isp1301-omap.c b/drivers/usb/phy/phy-isp1301-omap.c
index 4a6462c92ef2..6f4f74e6ba51 100644
--- a/drivers/usb/phy/phy-isp1301-omap.c
+++ b/drivers/usb/phy/phy-isp1301-omap.c
@@ -1566,13 +1566,13 @@ isp1301_probe(struct i2c_client *i2c, const struct i2c_device_id *id)

isp->phy.dev = &i2c->dev;
isp->phy.label = DRIVER_NAME;
- isp->phy.set_power = isp1301_set_power,
+ isp->phy.set_power = isp1301_set_power;

isp->phy.otg->usb_phy = &isp->phy;
- isp->phy.otg->set_host = isp1301_set_host,
- isp->phy.otg->set_peripheral = isp1301_set_peripheral,
- isp->phy.otg->start_srp = isp1301_start_srp,
- isp->phy.otg->start_hnp = isp1301_start_hnp,
+ isp->phy.otg->set_host = isp1301_set_host;
+ isp->phy.otg->set_peripheral = isp1301_set_peripheral;
+ isp->phy.otg->start_srp = isp1301_start_srp;
+ isp->phy.otg->start_hnp = isp1301_start_hnp;

enable_vbus_draw(isp, 0);
power_down(isp);
--
2.22.0

2020-12-15 05:29:52

by Peter Chen

Subject: Re: [PATCH -next] usb: phy: convert comma to semicolon

On 20-12-11 16:54:28, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun <[email protected]>

Reviewed-by: Peter Chen <[email protected]>

Peter
> ---
> drivers/usb/phy/phy-isp1301-omap.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-isp1301-omap.c b/drivers/usb/phy/phy-isp1301-omap.c
> index 4a6462c92ef2..6f4f74e6ba51 100644
> --- a/drivers/usb/phy/phy-isp1301-omap.c
> +++ b/drivers/usb/phy/phy-isp1301-omap.c
> @@ -1566,13 +1566,13 @@ isp1301_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
>
> isp->phy.dev = &i2c->dev;
> isp->phy.label = DRIVER_NAME;
> - isp->phy.set_power = isp1301_set_power,
> + isp->phy.set_power = isp1301_set_power;
>
> isp->phy.otg->usb_phy = &isp->phy;
> - isp->phy.otg->set_host = isp1301_set_host,
> - isp->phy.otg->set_peripheral = isp1301_set_peripheral,
> - isp->phy.otg->start_srp = isp1301_start_srp,
> - isp->phy.otg->start_hnp = isp1301_start_hnp,
> + isp->phy.otg->set_host = isp1301_set_host;
> + isp->phy.otg->set_peripheral = isp1301_set_peripheral;
> + isp->phy.otg->start_srp = isp1301_start_srp;
> + isp->phy.otg->start_hnp = isp1301_start_hnp;
>
> enable_vbus_draw(isp, 0);
> power_down(isp);
> --
> 2.22.0
>

--

Thanks,
Peter Chen