2020-12-17 05:50:20

by Nobuhiro Iwamatsu

[permalink] [raw]
Subject: [PATCH v5 0/4] gpio: visconti: Add Toshiba Visconti GPIO support

Hi,

This series is the GPIO driver for Toshiba's ARM SoC, Visconti[0].
This provides DT binding documentation, device driver, MAINTAINER files, and updates to DT files.

Best regards,
Nobuhiro

[0]: https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processors-visconti.html

dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller:
v4 -> v5: Drop interrupts property.
Add interrupts-parrent property.
v3 -> v4: Add Reviewed-by tag.
v2 -> v3: Fix dtschema/dtc warnings.
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.example.dt.yaml: gpio@28020000: interrupts: [[0, 24, 4], [0, 25, 4], [0, 26, 4], [0, 27, 4], [0, 28, 4], [0, 29, 4], [0, 30, 4], [0, 31, 4], [0, 32, 4], [0, 33, 4], [0, 34, 4], [0, 35, 4], [0, 36, 4], [0, 37, 4], [0, 38, 4], [0, 39, 4]] is too short
From schema: Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
v1 -> v2: Fix typo.

gpio: visoconti: Add Toshiba Visconti GPIO support:
v4 -> v5: Add IRQ_DOMAIN_HIERARCH to Kconfig
Updated for using hierarchical irqs.
v3 -> v4: Drop VISCONTI_GPIO_NR.
Fix return code of platform_irq_count.
Fix coprytight header.
Add Reviewed-by tag.
v2 -> v3: Add select GPIO_GENERIC
Use genric MMIO GPIO library
Use bgpio_init() as initialized the generic helpers.
Use irqchip template instead of gpiochip_irqchip_add().
v1 -> v2: No update

MAINTAINERS: Add entries for Toshiba Visconti GPIO controller:
v4 -> v5: No update
v3 -> v4: No update
v2 -> v3: No update
v1 -> v2: No update

arm: dts: visconti: Add DT support for Toshiba Visconti5 GPIO driver:
v4 -> v5: Drop interrupts property.
Add interrupts-parrent property.
v3 -> v4: Add Reviewed-by tag.
v2 -> v3: Fix compatible string.
v1 -> v2: No update

Nobuhiro Iwamatsu (4):
dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller
gpio: visconti: Add Toshiba Visconti GPIO support
MAINTAINERS: Add entries for Toshiba Visconti GPIO controller
arm: dts: visconti: Add DT support for Toshiba Visconti5 GPIO driver

.../bindings/gpio/toshiba,gpio-visconti.yaml | 70 ++++++
MAINTAINERS | 2 +
.../boot/dts/toshiba/tmpv7708-rm-mbrc.dts | 4 +
arch/arm64/boot/dts/toshiba/tmpv7708.dtsi | 11 +
drivers/gpio/Kconfig | 10 +
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-visconti.c | 218 ++++++++++++++++++
drivers/pinctrl/visconti/pinctrl-common.c | 23 ++
8 files changed, 339 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
create mode 100644 drivers/gpio/gpio-visconti.c

--
2.29.2


2020-12-17 05:51:26

by Nobuhiro Iwamatsu

[permalink] [raw]
Subject: [PATCH v5 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 GPIO driver

Add the GPIO node in Toshiba Visconti5 SoC-specific DT file.
And enable the GPIO node in TMPV7708 RM main board's board-specific DT file.

Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
Reviewed-by: Punit Agrawal <[email protected]>
---
arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts | 4 ++++
arch/arm64/boot/dts/toshiba/tmpv7708.dtsi | 11 +++++++++++
2 files changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
index ed0bf7f13f54..950010a290f0 100644
--- a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
+++ b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
@@ -41,3 +41,7 @@ &uart1 {
clocks = <&uart_clk>;
clock-names = "apb_pclk";
};
+
+&gpio {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
index 242f25f4e12a..17fdcbd4b075 100644
--- a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
+++ b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
@@ -157,6 +157,17 @@ pmux: pmux@24190000 {
reg = <0 0x24190000 0 0x10000>;
};

+ gpio: gpio@28020000 {
+ compatible = "toshiba,gpio-tmpv7708";
+ reg = <0 0x28020000 0 0x1000>;
+ #gpio-cells = <0x2>;
+ gpio-ranges = <&pmux 0 0 32>;
+ gpio-controller;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ interrupt-parent = <&gic>;
+ };
+
uart0: serial@28200000 {
compatible = "arm,pl011", "arm,primecell";
reg = <0 0x28200000 0 0x1000>;
--
2.29.2

2021-01-04 14:58:46

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v5 0/4] gpio: visconti: Add Toshiba Visconti GPIO support

On Thu, Dec 17, 2020 at 6:45 AM Nobuhiro Iwamatsu
<[email protected]> wrote:

> This series is the GPIO driver for Toshiba's ARM SoC, Visconti[0].
> This provides DT binding documentation, device driver, MAINTAINER files, and updates to DT files.

This v5 version looks just perfect :)
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2021-01-04 15:04:27

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v5 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 GPIO driver

On Thu, Dec 17, 2020 at 6:45 AM Nobuhiro Iwamatsu
<[email protected]> wrote:

> Add the GPIO node in Toshiba Visconti5 SoC-specific DT file.
> And enable the GPIO node in TMPV7708 RM main board's board-specific DT file.
>
> Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
> Reviewed-by: Punit Agrawal <[email protected]>

Acked-by: Linus Walleij <[email protected]>

Please funnel this patch through the ARM SoC tree.

Yours,
Linus Walleij