2020-12-18 10:44:29

by Xiaoming Ni

Subject: [PATCH] dma/qcom/gpi: Fixes a format mismatch

drivers/dma/qcom/gpi.c:1419:3: warning: format '%lu' expects argument of
type 'long unsigned int', but argument 8 has type 'size_t {aka unsigned
int}' [-Wformat=]
drivers/dma/qcom/gpi.c:1427:31: warning: format '%lu' expects argument of
type 'long unsigned int', but argument 3 has type 'size_t {aka unsigned
int}' [-Wformat=]
drivers/dma/qcom/gpi.c:1447:3: warning: format '%llx' expects argument of
type 'long long unsigned int', but argument 4 has type 'dma_addr_t {aka
unsigned int}' [-Wformat=]
drivers/dma/qcom/gpi.c:1447:3: warning: format '%llx' expects argument of
type 'long long unsigned int', but argument 5 has type 'phys_addr_t {aka
unsigned int}' [-Wformat=]

Signed-off-by: Xiaoming Ni <[email protected]>
---
drivers/dma/qcom/gpi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index d2334f535de2..556c070a514c 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -1416,7 +1416,7 @@ static int gpi_alloc_ring(struct gpi_ring *ring, u32 elements,
len = 1 << bit;
ring->alloc_size = (len + (len - 1));
dev_dbg(gpii->gpi_dev->dev,
- "#el:%u el_size:%u len:%u actual_len:%llu alloc_size:%lu\n",
+ "#el:%u el_size:%u len:%u actual_len:%llu alloc_size:%zu\n",
elements, el_size, (elements * el_size), len,
ring->alloc_size);

@@ -1424,7 +1424,7 @@ static int gpi_alloc_ring(struct gpi_ring *ring, u32 elements,
ring->alloc_size,
&ring->dma_handle, GFP_KERNEL);
if (!ring->pre_aligned) {
- dev_err(gpii->gpi_dev->dev, "could not alloc size:%lu mem for ring\n",
+ dev_err(gpii->gpi_dev->dev, "could not alloc size:%zu mem for ring\n",
ring->alloc_size);
return -ENOMEM;
}
@@ -1444,8 +1444,8 @@ static int gpi_alloc_ring(struct gpi_ring *ring, u32 elements,
smp_wmb();

dev_dbg(gpii->gpi_dev->dev,
- "phy_pre:0x%0llx phy_alig:0x%0llx len:%u el_size:%u elements:%u\n",
- ring->dma_handle, ring->phys_addr, ring->len,
+ "phy_pre:%pad phy_alig:%pa len:%u el_size:%u elements:%u\n",
+ &ring->dma_handle, &ring->phys_addr, ring->len,
ring->el_size, ring->elements);

return 0;
--
2.27.0

2020-12-21 05:01:11

by Bjorn Andersson

Subject: Re: [PATCH] dma/qcom/gpi: Fixes a format mismatch

On Fri 18 Dec 02:41 PST 2020, Xiaoming Ni wrote:

> drivers/dma/qcom/gpi.c:1419:3: warning: format '%lu' expects argument of
> type 'long unsigned int', but argument 8 has type 'size_t {aka unsigned
> int}' [-Wformat=]
> drivers/dma/qcom/gpi.c:1427:31: warning: format '%lu' expects argument of
> type 'long unsigned int', but argument 3 has type 'size_t {aka unsigned
> int}' [-Wformat=]
> drivers/dma/qcom/gpi.c:1447:3: warning: format '%llx' expects argument of
> type 'long long unsigned int', but argument 4 has type 'dma_addr_t {aka
> unsigned int}' [-Wformat=]
> drivers/dma/qcom/gpi.c:1447:3: warning: format '%llx' expects argument of
> type 'long long unsigned int', but argument 5 has type 'phys_addr_t {aka
> unsigned int}' [-Wformat=]
>

Reviewed-by: Bjorn Andersson <[email protected]>

> Signed-off-by: Xiaoming Ni <[email protected]>
> ---
> drivers/dma/qcom/gpi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index d2334f535de2..556c070a514c 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -1416,7 +1416,7 @@ static int gpi_alloc_ring(struct gpi_ring *ring, u32 elements,
> len = 1 << bit;
> ring->alloc_size = (len + (len - 1));
> dev_dbg(gpii->gpi_dev->dev,
> - "#el:%u el_size:%u len:%u actual_len:%llu alloc_size:%lu\n",
> + "#el:%u el_size:%u len:%u actual_len:%llu alloc_size:%zu\n",
> elements, el_size, (elements * el_size), len,
> ring->alloc_size);
>
> @@ -1424,7 +1424,7 @@ static int gpi_alloc_ring(struct gpi_ring *ring, u32 elements,
> ring->alloc_size,
> &ring->dma_handle, GFP_KERNEL);
> if (!ring->pre_aligned) {
> - dev_err(gpii->gpi_dev->dev, "could not alloc size:%lu mem for ring\n",
> + dev_err(gpii->gpi_dev->dev, "could not alloc size:%zu mem for ring\n",
> ring->alloc_size);
> return -ENOMEM;
> }
> @@ -1444,8 +1444,8 @@ static int gpi_alloc_ring(struct gpi_ring *ring, u32 elements,
> smp_wmb();
>
> dev_dbg(gpii->gpi_dev->dev,
> - "phy_pre:0x%0llx phy_alig:0x%0llx len:%u el_size:%u elements:%u\n",
> - ring->dma_handle, ring->phys_addr, ring->len,
> + "phy_pre:%pad phy_alig:%pa len:%u el_size:%u elements:%u\n",
> + &ring->dma_handle, &ring->phys_addr, ring->len,
> ring->el_size, ring->elements);
>
> return 0;
> --
> 2.27.0
>

2020-12-21 14:13:39

by Vinod Koul

Subject: Re: [PATCH] dma/qcom/gpi: Fixes a format mismatch

On 18-12-20, 18:41, Xiaoming Ni wrote:
> drivers/dma/qcom/gpi.c:1419:3: warning: format '%lu' expects argument of
> type 'long unsigned int', but argument 8 has type 'size_t {aka unsigned
> int}' [-Wformat=]
> drivers/dma/qcom/gpi.c:1427:31: warning: format '%lu' expects argument of
> type 'long unsigned int', but argument 3 has type 'size_t {aka unsigned
> int}' [-Wformat=]
> drivers/dma/qcom/gpi.c:1447:3: warning: format '%llx' expects argument of
> type 'long long unsigned int', but argument 4 has type 'dma_addr_t {aka
> unsigned int}' [-Wformat=]
> drivers/dma/qcom/gpi.c:1447:3: warning: format '%llx' expects argument of
> type 'long long unsigned int', but argument 5 has type 'phys_addr_t {aka
> unsigned int}' [-Wformat=]

The subsystem is dmaengine: please use right tags (hint git log will
tell you so)

I have fixed it up while applying, thanks

--
~Vinod