2020-12-22 18:18:38

by Abhishek Pandit-Subedi

Subject: [PATCH] Bluetooth: btrtl: Enable central-peripheral role

Enable the central-peripheral role on RTL8822CE. This enables creating
connections while there is an existing connection in the slave role.

This change can be confirmed in userspace via `bluetoothctl show` which
will now show "Roles: central-peripheral".

Reviewed-by: Daniel Winkler <[email protected]>
Signed-off-by: Abhishek Pandit-Subedi <[email protected]>
---

drivers/bluetooth/btrtl.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 94df4e94999d5c8..1abf6a4d672734f 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -714,13 +714,24 @@ int btrtl_setup_realtek(struct hci_dev *hdev)

ret = btrtl_download_firmware(hdev, btrtl_dev);

- btrtl_free(btrtl_dev);
-
/* Enable controller to do both LE scan and BR/EDR inquiry
* simultaneously.
*/
set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks);

+ /* Enable central-peripheral role (able to create new connections with
+ * an existing connection in slave role).
+ */
+ switch (btrtl_dev->ic_info->lmp_subver) {
+ case RTL_ROM_LMP_8822B:
+ set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
+ break;
+ default:
+ rtl_dev_dbg(hdev, "Central-peripheral role not enabled.");
+ break;
+ }
+
+ btrtl_free(btrtl_dev);
return ret;
}
EXPORT_SYMBOL_GPL(btrtl_setup_realtek);
--
2.29.2.729.g45daf8777d-goog

2020-12-22 21:04:24

by Marcel Holtmann

Subject: Re: [PATCH] Bluetooth: btrtl: Enable central-peripheral role

Hi Abhishek,

> Enable the central-peripheral role on RTL8822CE. This enables creating
> connections while there is an existing connection in the slave role.
>
> This change can be confirmed in userspace via `bluetoothctl show` which
> will now show "Roles: central-peripheral".
>
> Reviewed-by: Daniel Winkler <[email protected]>
> Signed-off-by: Abhishek Pandit-Subedi <[email protected]>
> ---
>
> drivers/bluetooth/btrtl.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel