2020-12-24 11:32:24

by Nikita Shubin

Subject: [RFC PATCH 3/3] gpio: ep93xx: specify gpio_irq_chip->first

Port F irq's should be statically mapped to EP93XX_GPIO_F_IRQ_BASE.

So we need to specify girq->first otherwise:

"If device tree is used, then first_irq will be 0 and
irqs get mapped dynamically on the fly"

And that's not the thing we want.

Signed-off-by: Nikita Shubin <[email protected]>
---
drivers/gpio/gpio-ep93xx.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
index 90afe07213ce..a321a7441294 100644
--- a/drivers/gpio/gpio-ep93xx.c
+++ b/drivers/gpio/gpio-ep93xx.c
@@ -402,6 +402,7 @@ static int ep93xx_gpio_add_f_irq_chip(struct gpio_chip *gc,
}
girq->default_type = IRQ_TYPE_NONE;
girq->handler = handle_level_irq;
+ girq->first = EP93XX_GPIO_F_IRQ_BASE;

return 0;
}
--
2.26.2

2020-12-27 21:24:41

by Linus Walleij

Subject: Re: [RFC PATCH 3/3] gpio: ep93xx: specify gpio_irq_chip->first

On Thu, Dec 24, 2020 at 12:22 PM Nikita Shubin
<[email protected]> wrote:

> Port F irq's should be statically mapped to EP93XX_GPIO_F_IRQ_BASE.
>
> So we need to specify girq->first otherwise:
>
> "If device tree is used, then first_irq will be 0 and
> irqs get mapped dynamically on the fly"
>
> And that's not the thing we want.
>
> Signed-off-by: Nikita Shubin <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

We can only fix this properly once we convert the platform
to device tree. (Along with making the irqchip hierarchical.)

Yours,
Linus Walleij