2020-12-26 01:40:13

by Nathan Chancellor

Subject: [PATCH] mfd: ab8500-debugfs: Remove extraneous curly brace

Clang errors:

../drivers/mfd/ab8500-debugfs.c:1526:2: error: non-void function does
not return a value [-Werror,-Wreturn-type]
}
^
../drivers/mfd/ab8500-debugfs.c:1528:2: error: expected identifier or '('
return 0;
^
../drivers/mfd/ab8500-debugfs.c:1529:1: error: extraneous closing brace ('}')
}
^
3 errors generated.

The cleanup in ab8500_interrupts_show left a curly brace around, remove
it to fix the error.

Fixes: 886c8121659d ("mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc")
Signed-off-by: Nathan Chancellor <[email protected]>
---
drivers/mfd/ab8500-debugfs.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
index a32039366a93..1cf84562351e 100644
--- a/drivers/mfd/ab8500-debugfs.c
+++ b/drivers/mfd/ab8500-debugfs.c
@@ -1521,7 +1521,6 @@ static int ab8500_interrupts_show(struct seq_file *s, void *p)
line + irq_first,
num_interrupts[line],
num_wake_interrupts[line]);
- }
seq_putc(s, '\n');
}


base-commit: 61d791365b72a89062fbbea69aa61479476da946
--
2.30.0.rc1

2020-12-26 07:06:54

by Joe Perches

Subject: Re: [PATCH] mfd: ab8500-debugfs: Remove extraneous curly brace

On Fri, 2020-12-25 at 18:35 -0700, Nathan Chancellor wrote:
> Clang errors:
>
> ../drivers/mfd/ab8500-debugfs.c:1526:2: error: non-void function does
> not return a value [-Werror,-Wreturn-type]
> ????????}
> ????????^
> ../drivers/mfd/ab8500-debugfs.c:1528:2: error: expected identifier or '('
> return 0;
> ????????^
> ../drivers/mfd/ab8500-debugfs.c:1529:1: error: extraneous closing brace ('}')
> }
> ^
> 3 errors generated.
>
> The cleanup in ab8500_interrupts_show left a curly brace around, remove
> it to fix the error.
>
> Fixes: 886c8121659d ("mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc")
> Signed-off-by: Nathan Chancellor <[email protected]>
> ---
> ?drivers/mfd/ab8500-debugfs.c | 1 -
> ?1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
[]
> @@ -1521,7 +1521,6 @@ static int ab8500_interrupts_show(struct seq_file *s, void *p)
> ? line + irq_first,
> ? num_interrupts[line],
> ? num_wake_interrupts[line]);
> - }
> ? seq_putc(s, '\n');

It looks as if this seq_putc should be removed as well
as the seq_printf above already ends in a newline.

> ? }
> ?
>
>
> base-commit: 61d791365b72a89062fbbea69aa61479476da946