2020-12-26 03:34:06

by chenzhou

[permalink] [raw]
Subject: [PATCH 0/2] arm64: mm: fix kdump broken with ZONE_DMA reintroduced

If the memory reserved for crash dump kernel falled in ZONE_DMA32,
the devices in crash dump kernel need to use ZONE_DMA will alloc fail.

Fix this by reserving low memory in ZONE_DMA if CONFIG_ZONE_DMA is
enabled, otherwise, reserving in ZONE_DMA32.

Patch 1 updates the comments about the ZONE_DMA.
Patch 2 fix kdump broken.

Chen Zhou (2):
arm64: mm: update the comments about ZONE_DMA
arm64: mm: fix kdump broken with ZONE_DMA reintroduced

arch/arm64/mm/init.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)

--
2.20.1


2021-01-20 13:19:50

by Will Deacon

[permalink] [raw]
Subject: Re: [PATCH 0/2] arm64: mm: fix kdump broken with ZONE_DMA reintroduced

On Sat, Dec 26, 2020 at 11:35:55AM +0800, Chen Zhou wrote:
> If the memory reserved for crash dump kernel falled in ZONE_DMA32,
> the devices in crash dump kernel need to use ZONE_DMA will alloc fail.
>
> Fix this by reserving low memory in ZONE_DMA if CONFIG_ZONE_DMA is
> enabled, otherwise, reserving in ZONE_DMA32.
>
> Patch 1 updates the comments about the ZONE_DMA.
> Patch 2 fix kdump broken.
>
> Chen Zhou (2):
> arm64: mm: update the comments about ZONE_DMA
> arm64: mm: fix kdump broken with ZONE_DMA reintroduced

Please can you repost this if it is still needed after the changes that
landed in -rc4?

Will

2021-01-20 13:21:17

by Catalin Marinas

[permalink] [raw]
Subject: Re: [PATCH 0/2] arm64: mm: fix kdump broken with ZONE_DMA reintroduced

On Wed, Jan 20, 2021 at 12:40:55PM +0000, Will Deacon wrote:
> On Sat, Dec 26, 2020 at 11:35:55AM +0800, Chen Zhou wrote:
> > If the memory reserved for crash dump kernel falled in ZONE_DMA32,
> > the devices in crash dump kernel need to use ZONE_DMA will alloc fail.
> >
> > Fix this by reserving low memory in ZONE_DMA if CONFIG_ZONE_DMA is
> > enabled, otherwise, reserving in ZONE_DMA32.
> >
> > Patch 1 updates the comments about the ZONE_DMA.
> > Patch 2 fix kdump broken.
> >
> > Chen Zhou (2):
> > arm64: mm: update the comments about ZONE_DMA
> > arm64: mm: fix kdump broken with ZONE_DMA reintroduced
>
> Please can you repost this if it is still needed after the changes that
> landed in -rc4?

I don't think this series is needed anymore but I'll let Chen confirm.

--
Catalin

2021-01-21 03:36:41

by chenzhou

[permalink] [raw]
Subject: Re: [PATCH 0/2] arm64: mm: fix kdump broken with ZONE_DMA reintroduced

Hi Will, Catalin,


On 2021/1/20 21:07, Catalin Marinas wrote:
> On Wed, Jan 20, 2021 at 12:40:55PM +0000, Will Deacon wrote:
>> On Sat, Dec 26, 2020 at 11:35:55AM +0800, Chen Zhou wrote:
>>> If the memory reserved for crash dump kernel falled in ZONE_DMA32,
>>> the devices in crash dump kernel need to use ZONE_DMA will alloc fail.
>>>
>>> Fix this by reserving low memory in ZONE_DMA if CONFIG_ZONE_DMA is
>>> enabled, otherwise, reserving in ZONE_DMA32.
>>>
>>> Patch 1 updates the comments about the ZONE_DMA.
>>> Patch 2 fix kdump broken.
>>>
>>> Chen Zhou (2):
>>> arm64: mm: update the comments about ZONE_DMA
>>> arm64: mm: fix kdump broken with ZONE_DMA reintroduced
>> Please can you repost this if it is still needed after the changes that
>> landed in -rc4?
> I don't think this series is needed anymore but I'll let Chen confirm.
Yes, we don't need this series, Catalin has solved the issue i mentioned.

I will repost the series "support reserving crashkernel above 4G on arm64 kdump"
based on the latest code.

Thanks,
Chen Zhou