2020-12-29 20:50:06

by Nathan Chancellor

Subject: [PATCH] pinctrl: nomadik: Remove unused variable in nmk_gpio_dbg_show_one

Clang warns:

drivers/pinctrl/nomadik/pinctrl-nomadik.c:952:8: warning: unused
variable 'wake' [-Wunused-variable]
bool wake;
^
1 warning generated.

There were two wake declarations added to nmk_gpio_dbg_show_one when
converting it to use irq_has_action but only one is used within its
scope. Remove the unused one so there is no more warning.

Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
Signed-off-by: Nathan Chancellor <[email protected]>
---
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index d4ea10803fd9..abfe11c7b49f 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -949,7 +949,6 @@ static void nmk_gpio_dbg_show_one(struct seq_file *s,
} else {
int irq = chip->to_irq(chip, offset);
const int pullidx = pull ? 1 : 0;
- bool wake;
int val;
static const char * const pulls[] = {
"none ",

base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e
--
2.30.0

2021-01-05 15:20:27

by Linus Walleij

Subject: Re: [PATCH] pinctrl: nomadik: Remove unused variable in nmk_gpio_dbg_show_one

On Tue, Dec 29, 2020 at 9:47 PM Nathan Chancellor
<[email protected]> wrote:

> drivers/pinctrl/nomadik/pinctrl-nomadik.c:952:8: warning: unused
> variable 'wake' [-Wunused-variable]
> bool wake;
> ^
> 1 warning generated.
>
> There were two wake declarations added to nmk_gpio_dbg_show_one when
> converting it to use irq_has_action but only one is used within its
> scope. Remove the unused one so there is no more warning.
>
> Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
> Signed-off-by: Nathan Chancellor <[email protected]>

Patch applied.

Yours,
Linus Walleij