2021-01-01 12:59:49

by Jiaxun Yang

Subject: [PATCH 1/2] ACPI: platform-profile: Introduce data parameter to handler

Add a data parameter to handler callbacks to avoid having
global variables everywhere.

Signed-off-by: Jiaxun Yang <[email protected]>
---
drivers/acpi/platform_profile.c | 4 ++--
include/linux/platform_profile.h | 5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
index 91be50a32cc8..60072f6e032d 100644
--- a/drivers/acpi/platform_profile.c
+++ b/drivers/acpi/platform_profile.c
@@ -64,7 +64,7 @@ static ssize_t platform_profile_show(struct device *dev,
return -ENODEV;
}

- err = cur_profile->profile_get(&profile);
+ err = cur_profile->profile_get(cur_profile->data, &profile);
mutex_unlock(&profile_lock);
if (err)
return err;
@@ -104,7 +104,7 @@ static ssize_t platform_profile_store(struct device *dev,
return -EOPNOTSUPP;
}

- err = cur_profile->profile_set(i);
+ err = cur_profile->profile_set(cur_profile->data, i);
mutex_unlock(&profile_lock);
if (err)
return err;
diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h
index 3623d7108421..272faf55875d 100644
--- a/include/linux/platform_profile.h
+++ b/include/linux/platform_profile.h
@@ -27,9 +27,10 @@ enum platform_profile_option {
};

struct platform_profile_handler {
+ void *data;
unsigned long choices[BITS_TO_LONGS(PLATFORM_PROFILE_LAST)];
- int (*profile_get)(enum platform_profile_option *profile);
- int (*profile_set)(enum platform_profile_option profile);
+ int (*profile_get)(void *data, enum platform_profile_option *profile);
+ int (*profile_set)(void *data, enum platform_profile_option profile);
};

int platform_profile_register(const struct platform_profile_handler *pprof);
--
2.30.0

2021-01-04 14:36:50

by Hans de Goede

Subject: Re: [PATCH 1/2] ACPI: platform-profile: Introduce data parameter to handler

Hi,

On 1/1/21 1:56 PM, Jiaxun Yang wrote:
> Add a data parameter to handler callbacks to avoid having
> global variables everywhere.
>
> Signed-off-by: Jiaxun Yang <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans



> ---
> drivers/acpi/platform_profile.c | 4 ++--
> include/linux/platform_profile.h | 5 +++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
> index 91be50a32cc8..60072f6e032d 100644
> --- a/drivers/acpi/platform_profile.c
> +++ b/drivers/acpi/platform_profile.c
> @@ -64,7 +64,7 @@ static ssize_t platform_profile_show(struct device *dev,
> return -ENODEV;
> }
>
> - err = cur_profile->profile_get(&profile);
> + err = cur_profile->profile_get(cur_profile->data, &profile);
> mutex_unlock(&profile_lock);
> if (err)
> return err;
> @@ -104,7 +104,7 @@ static ssize_t platform_profile_store(struct device *dev,
> return -EOPNOTSUPP;
> }
>
> - err = cur_profile->profile_set(i);
> + err = cur_profile->profile_set(cur_profile->data, i);
> mutex_unlock(&profile_lock);
> if (err)
> return err;
> diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h
> index 3623d7108421..272faf55875d 100644
> --- a/include/linux/platform_profile.h
> +++ b/include/linux/platform_profile.h
> @@ -27,9 +27,10 @@ enum platform_profile_option {
> };
>
> struct platform_profile_handler {
> + void *data;
> unsigned long choices[BITS_TO_LONGS(PLATFORM_PROFILE_LAST)];
> - int (*profile_get)(enum platform_profile_option *profile);
> - int (*profile_set)(enum platform_profile_option profile);
> + int (*profile_get)(void *data, enum platform_profile_option *profile);
> + int (*profile_set)(void *data, enum platform_profile_option profile);
> };
>
> int platform_profile_register(const struct platform_profile_handler *pprof);
>