2020-12-02 14:04:08

by Adam Ford

Subject: [PATCH] arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing

The WiFi chip is capable of communication at SDR104 speeds, and
the pinmux was configured to support this, but the sdhc1 controller
didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux
as was originally intended.

Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
Signed-off-by: Adam Ford <[email protected]>

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
index 6de86a4f0ec4..90fd15e95798 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
@@ -217,8 +217,10 @@
&usdhc1 {
#address-cells = <1>;
#size-cells = <0>;
- pinctrl-names = "default";
+ pinctrl-names = "default", "state_100mhz", "state_200mhz";
pinctrl-0 = <&pinctrl_usdhc1>;
+ pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+ pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
bus-width = <4>;
non-removable;
cap-power-off-card;
--
2.17.1

2021-01-05 03:05:03

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing

On Wed, Dec 02, 2020 at 07:59:50AM -0600, Adam Ford wrote:
> The WiFi chip is capable of communication at SDR104 speeds, and
> the pinmux was configured to support this, but the sdhc1 controller
> didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux
> as was originally intended.
>
> Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")

This looks more like an improvement than bug fix.

Shawn

> Signed-off-by: Adam Ford <[email protected]>
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> index 6de86a4f0ec4..90fd15e95798 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> @@ -217,8 +217,10 @@
> &usdhc1 {
> #address-cells = <1>;
> #size-cells = <0>;
> - pinctrl-names = "default";
> + pinctrl-names = "default", "state_100mhz", "state_200mhz";
> pinctrl-0 = <&pinctrl_usdhc1>;
> + pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
> + pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
> bus-width = <4>;
> non-removable;
> cap-power-off-card;
> --
> 2.17.1
>

2021-01-05 13:24:22

by Adam Ford

Subject: Re: [PATCH] arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing

On Mon, Jan 4, 2021 at 9:03 PM Shawn Guo <[email protected]> wrote:
>
> On Wed, Dec 02, 2020 at 07:59:50AM -0600, Adam Ford wrote:
> > The WiFi chip is capable of communication at SDR104 speeds, and
> > the pinmux was configured to support this, but the sdhc1 controller
> > didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux
> > as was originally intended.
> >
> > Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
>
> This looks more like an improvement than bug fix.

Do you want me to resubmit without the fixes tag?

adam
>
> Shawn
>
> > Signed-off-by: Adam Ford <[email protected]>
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > index 6de86a4f0ec4..90fd15e95798 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > @@ -217,8 +217,10 @@
> > &usdhc1 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > - pinctrl-names = "default";
> > + pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > pinctrl-0 = <&pinctrl_usdhc1>;
> > + pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
> > + pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
> > bus-width = <4>;
> > non-removable;
> > cap-power-off-card;
> > --
> > 2.17.1
> >

2021-01-05 14:11:14

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing

On Tue, Jan 05, 2021 at 06:48:13AM -0600, Adam Ford wrote:
> On Mon, Jan 4, 2021 at 9:03 PM Shawn Guo <[email protected]> wrote:
> >
> > On Wed, Dec 02, 2020 at 07:59:50AM -0600, Adam Ford wrote:
> > > The WiFi chip is capable of communication at SDR104 speeds, and
> > > the pinmux was configured to support this, but the sdhc1 controller
> > > didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux
> > > as was originally intended.
> > >
> > > Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
> >
> > This looks more like an improvement than bug fix.
>
> Do you want me to resubmit without the fixes tag?

Yes, please. Also, update patch subject like below maybe.

arm64: dts: imx8mm-beacon: add more pinctrl states for usdhc1

Shawn