2021-01-05 15:19:34

by Kishon Vijay Abraham I

[permalink] [raw]
Subject: [PATCH v4 0/6] PCI: J7200/J721E PCIe bindings

Patch series adds DT nodes in order to get PCIe working in J7200.
Also includes couple of fixes for J721e.

v1 of the patch series can be found @ [1]
v2 of the patch series can be found @ [2]
v3 of the patch series can be found @ [3]

Changes from v3:
1) Removed Fixes tag as the patches doesn't have to be backported

Changes from v2:
1) Moved serdes_refclk node out of interconnect node and also replaced
"_" with "-"

Changes from v1:
1) Include only the device tree patches here (the binding patch is sent
separately)
2) Include couple of patches that fixes J721E DTS.

[1] -> http://lore.kernel.org/r/[email protected]
[2] -> http://lore.kernel.org/r/[email protected]
[3] -> http://lore.kernel.org/r/[email protected]

Kishon Vijay Abraham I (6):
arm64: dts: ti: k3-j721e-main: Fix supported max outbound regions
arm64: dts: ti: k3-j721e-main: Remove "syscon" nodes added for
pcieX_ctrl
arm64: dts: ti: k3-j7200-main: Add SERDES and WIZ device tree node
arm64: dts: ti: k3-j7200-main: Add PCIe device tree node
arm64: dts: ti: k3-j7200-common-proc-board: Enable SERDES0
arm64: dts: ti: k3-j7200-common-proc-board: Enable PCIe

.../dts/ti/k3-j7200-common-proc-board.dts | 38 ++++++
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 111 ++++++++++++++++++
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 52 ++------
3 files changed, 157 insertions(+), 44 deletions(-)

--
2.17.1


2021-01-05 15:20:07

by Kishon Vijay Abraham I

[permalink] [raw]
Subject: [PATCH v4 4/6] arm64: dts: ti: k3-j7200-main: Add PCIe device tree node

Add PCIe device tree node (both RC and EP) for the single PCIe
instance present in j7200.

Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 48 +++++++++++++++++++++++
1 file changed, 48 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
index fbe4cd1e6e09..4e39f0325c03 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
@@ -594,6 +594,54 @@
};
};

+ pcie1_rc: pcie@2910000 {
+ compatible = "ti,j7200-pcie-host", "ti,j721e-pcie-host";
+ reg = <0x00 0x02910000 0x00 0x1000>,
+ <0x00 0x02917000 0x00 0x400>,
+ <0x00 0x0d800000 0x00 0x00800000>,
+ <0x00 0x18000000 0x00 0x00001000>;
+ reg-names = "intd_cfg", "user_cfg", "reg", "cfg";
+ interrupt-names = "link_state";
+ interrupts = <GIC_SPI 330 IRQ_TYPE_EDGE_RISING>;
+ device_type = "pci";
+ ti,syscon-pcie-ctrl = <&scm_conf 0x4074>;
+ max-link-speed = <3>;
+ num-lanes = <4>;
+ power-domains = <&k3_pds 240 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 240 6>;
+ clock-names = "fck";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ bus-range = <0x0 0xf>;
+ cdns,no-bar-match-nbits = <64>;
+ vendor-id = /bits/ 16 <0x104c>;
+ device-id = /bits/ 16 <0xb00f>;
+ msi-map = <0x0 &gic_its 0x0 0x10000>;
+ dma-coherent;
+ ranges = <0x01000000 0x0 0x18001000 0x00 0x18001000 0x0 0x0010000>,
+ <0x02000000 0x0 0x18011000 0x00 0x18011000 0x0 0x7fef000>;
+ dma-ranges = <0x02000000 0x0 0x0 0x0 0x0 0x10000 0x0>;
+ };
+
+ pcie1_ep: pcie-ep@2910000 {
+ compatible = "ti,j7200-pcie-ep", "ti,j721e-pcie-ep";
+ reg = <0x00 0x02910000 0x00 0x1000>,
+ <0x00 0x02917000 0x00 0x400>,
+ <0x00 0x0d800000 0x00 0x00800000>,
+ <0x00 0x18000000 0x00 0x08000000>;
+ reg-names = "intd_cfg", "user_cfg", "reg", "mem";
+ interrupt-names = "link_state";
+ interrupts = <GIC_SPI 330 IRQ_TYPE_EDGE_RISING>;
+ ti,syscon-pcie-ctrl = <&scm_conf 0x4074>;
+ max-link-speed = <3>;
+ num-lanes = <4>;
+ power-domains = <&k3_pds 240 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 240 6>;
+ clock-names = "fck";
+ max-functions = /bits/ 8 <6>;
+ dma-coherent;
+ };
+
usbss0: cdns-usb@4104000 {
compatible = "ti,j721e-usb";
reg = <0x00 0x4104000 0x00 0x100>;
--
2.17.1

2021-01-11 14:14:12

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH v4 0/6] PCI: J7200/J721E PCIe bindings

Hi,

On 1/5/21 8:44 PM, Kishon Vijay Abraham I wrote:
> Patch series adds DT nodes in order to get PCIe working in J7200.
> Also includes couple of fixes for J721e.
[...]
>
> Kishon Vijay Abraham I (6):
> arm64: dts: ti: k3-j721e-main: Fix supported max outbound regions
> arm64: dts: ti: k3-j721e-main: Remove "syscon" nodes added for
> pcieX_ctrl
> arm64: dts: ti: k3-j7200-main: Add SERDES and WIZ device tree node
> arm64: dts: ti: k3-j7200-main: Add PCIe device tree node
> arm64: dts: ti: k3-j7200-common-proc-board: Enable SERDES0
> arm64: dts: ti: k3-j7200-common-proc-board: Enable PCIe
>
> .../dts/ti/k3-j7200-common-proc-board.dts | 38 ++++++
> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 111 ++++++++++++++++++
> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 52 ++------
> 3 files changed, 157 insertions(+), 44 deletions(-)
>


For the series:

Reviewed-by: Vignesh Raghavendra <[email protected]>

Regards
Vignesh

2021-01-11 14:26:58

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH v4 0/6] PCI: J7200/J721E PCIe bindings

On Tue, 5 Jan 2021 20:44:15 +0530, Kishon Vijay Abraham I wrote:
> Patch series adds DT nodes in order to get PCIe working in J7200.
> Also includes couple of fixes for J721e.
>
> v1 of the patch series can be found @ [1]
> v2 of the patch series can be found @ [2]
> v3 of the patch series can be found @ [3]
>
> [...]

Hi Kishon Vijay Abraham I,

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/6] arm64: dts: ti: k3-j721e-main: Fix supported max outbound regions
commit: 0e3cfb868137cf7ced91d7dc709961000c0dae29
[2/6] arm64: dts: ti: k3-j721e-main: Remove "syscon" nodes added for pcieX_ctrl
commit: edb96779f3bcbe348f82b458077de0fb96118233
[3/6] arm64: dts: ti: k3-j7200-main: Add SERDES and WIZ device tree node
commit: 4c1b22a953d9f8af4d5c2f238fb74dc190d92f04
[4/6] arm64: dts: ti: k3-j7200-main: Add PCIe device tree node
commit: 3276d9f53cf660f8ed60d98918170670d0ca6e54
[5/6] arm64: dts: ti: k3-j7200-common-proc-board: Enable SERDES0
commit: 429c0259f17f4fdf9c0beb5423b0c8f6c2ea2e8c
[6/6] arm64: dts: ti: k3-j7200-common-proc-board: Enable PCIe
commit: 3a6319df506f1a821abad2c71a580a2f7b78a304


All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D