2021-01-05 13:49:16

by Masanari Iida

Subject: [PATCH] csky: Fix a typo in Kconfig

This patch fixes a spelling typo in Kconfig.

Signed-off-by: Masanari Iida <[email protected]>
---
arch/csky/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
index 7f1721101ea0..ce680f6e3b4b 100644
--- a/arch/csky/Kconfig
+++ b/arch/csky/Kconfig
@@ -243,7 +243,7 @@ menuconfig HAVE_TCM
bool "Tightly-Coupled/Sram Memory"
select GENERIC_ALLOCATOR
help
- The implementation are not only used by TCM (Tightly-Coupled Meory)
+ The implementation are not only used by TCM (Tightly-Coupled Memory)
but also used by sram on SOC bus. It follow existed linux tcm
software interface, so that old tcm application codes could be
re-used directly.
--
2.25.0

2021-01-05 23:05:40

by Randy Dunlap

Subject: Re: [PATCH] csky: Fix a typo in Kconfig

Hi,
There's a lot more to do here. Please see below.

On 1/5/21 5:41 AM, Masanari Iida wrote:
> This patch fixes a spelling typo in Kconfig.
>
> Signed-off-by: Masanari Iida <[email protected]>
> ---
> arch/csky/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
> index 7f1721101ea0..ce680f6e3b4b 100644
> --- a/arch/csky/Kconfig
> +++ b/arch/csky/Kconfig
> @@ -243,7 +243,7 @@ menuconfig HAVE_TCM
> bool "Tightly-Coupled/Sram Memory"
> select GENERIC_ALLOCATOR
> help
> - The implementation are not only used by TCM (Tightly-Coupled Meory)
> + The implementation are not only used by TCM (Tightly-Coupled Memory)

is not

> but also used by sram on SOC bus. It follow existed linux tcm

SRAM follows the existing Linux TCM

> software interface, so that old tcm application codes could be

TCM

> re-used directly.
>


--
~Randy

2021-01-06 10:08:50

by Masanari Iida

Subject: [PATCH/v2] csky: Fix typos in Kconfig

This patch fixes some spelling typos in Kconfig.

Signed-off-by: Masanari Iida <[email protected]>
---
arch/csky/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
index 7f1721101ea0..e6ddca10e3ee 100644
--- a/arch/csky/Kconfig
+++ b/arch/csky/Kconfig
@@ -243,9 +243,9 @@ menuconfig HAVE_TCM
bool "Tightly-Coupled/Sram Memory"
select GENERIC_ALLOCATOR
help
- The implementation are not only used by TCM (Tightly-Coupled Meory)
- but also used by sram on SOC bus. It follow existed linux tcm
- software interface, so that old tcm application codes could be
+ The implementation is not only used by TCM (Tightly-Coupled Memory)
+ but also used by SRAM on SOC bus. It follows the existing Linux TCM
+ software interface, so that old TCM application codes could be
re-used directly.

if HAVE_TCM
--
2.25.0

2021-01-06 16:26:37

by Randy Dunlap

Subject: Re: [PATCH/v2] csky: Fix typos in Kconfig

On 1/6/21 2:04 AM, Masanari Iida wrote:
> This patch fixes some spelling typos in Kconfig.
>
> Signed-off-by: Masanari Iida <[email protected]>
> ---
> arch/csky/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
> index 7f1721101ea0..e6ddca10e3ee 100644
> --- a/arch/csky/Kconfig
> +++ b/arch/csky/Kconfig
> @@ -243,9 +243,9 @@ menuconfig HAVE_TCM
> bool "Tightly-Coupled/Sram Memory"
> select GENERIC_ALLOCATOR
> help
> - The implementation are not only used by TCM (Tightly-Coupled Meory)
> - but also used by sram on SOC bus. It follow existed linux tcm
> - software interface, so that old tcm application codes could be
> + The implementation is not only used by TCM (Tightly-Coupled Memory)
> + but also used by SRAM on SOC bus. It follows the existing Linux TCM
> + software interface, so that old TCM application codes could be
> re-used directly.
>
> if HAVE_TCM
>

LGTM. Thanks.
Reviewed-by: Randy Dunlap <[email protected]>

--
~Randy

2021-01-07 16:27:46

by Guo Ren

Subject: Re: [PATCH/v2] csky: Fix typos in Kconfig

Thx, looks good to me.


On Thu, Jan 7, 2021 at 12:23 AM Randy Dunlap <[email protected]> wrote:
>
> On 1/6/21 2:04 AM, Masanari Iida wrote:
> > This patch fixes some spelling typos in Kconfig.
> >
> > Signed-off-by: Masanari Iida <[email protected]>
> > ---
> > arch/csky/Kconfig | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
> > index 7f1721101ea0..e6ddca10e3ee 100644
> > --- a/arch/csky/Kconfig
> > +++ b/arch/csky/Kconfig
> > @@ -243,9 +243,9 @@ menuconfig HAVE_TCM
> > bool "Tightly-Coupled/Sram Memory"
> > select GENERIC_ALLOCATOR
> > help
> > - The implementation are not only used by TCM (Tightly-Coupled Meory)
> > - but also used by sram on SOC bus. It follow existed linux tcm
> > - software interface, so that old tcm application codes could be
> > + The implementation is not only used by TCM (Tightly-Coupled Memory)
> > + but also used by SRAM on SOC bus. It follows the existing Linux TCM
> > + software interface, so that old TCM application codes could be
> > re-used directly.
> >
> > if HAVE_TCM
> >
>
> LGTM. Thanks.
> Reviewed-by: Randy Dunlap <[email protected]>
>
> --
> ~Randy



--
Best Regards
Guo Ren

ML: https://lore.kernel.org/linux-csky/