2021-01-06 13:10:37

by Jeremy Szu

Subject: [PATCH] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines

* The HP ZBook Fury 15/17 G7 Mobile Workstation are using ALC285 codec
which is using 0x04 to control mute LED and 0x01 to control micmute LED.

* The right channel speaker is no sound and it needs to expose GPIO1 for
initialing AMP.

Add quirks to support them.

Signed-off-by: Jeremy Szu <[email protected]>
---
sound/pci/hda/patch_realtek.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3c1d2a3fb1a4..dd82ff2bd5d6 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7970,6 +7970,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8760, "HP", ALC285_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x877a, "HP", ALC285_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x877d, "HP", ALC236_FIXUP_HP_MUTE_LED),
+ SND_PCI_QUIRK(0x103c, 0x8780, "HP ZBook Fury 17 G7 Mobile Workstation",
+ ALC285_FIXUP_HP_GPIO_AMP_INIT),
+ SND_PCI_QUIRK(0x103c, 0x8783, "HP ZBook Fury 15 G7 Mobile Workstation",
+ ALC285_FIXUP_HP_GPIO_AMP_INIT),
SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
--
2.29.2

2021-01-07 10:42:50

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines

On Wed, 06 Jan 2021 14:05:46 +0100,
Jeremy Szu wrote:
>
> * The HP ZBook Fury 15/17 G7 Mobile Workstation are using ALC285 codec
> which is using 0x04 to control mute LED and 0x01 to control micmute LED.
>
> * The right channel speaker is no sound and it needs to expose GPIO1 for
> initialing AMP.
>
> Add quirks to support them.
>
> Signed-off-by: Jeremy Szu <[email protected]>

Thanks, applied now.


Takashi

2022-03-15 10:46:08

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines

On Mon, 14 Mar 2022 15:21:19 +0100,
Andy Chi wrote:
>
> * The HP ProBook 440/450 and EliteBook 640/650 are
> using ALC236 codec which used 0x02 to control mute LED
> and 0x01 to control micmute LED. Therefore, add a quirk to make it works.
>
> Signed-off-by: Andy Chi <[email protected]>

Thanks, applied now.


Takashi