2021-01-06 13:21:28

by Zheng Yongjun

Subject: [PATCH -next] mtd: st_spi_fsm: use resource_size

Use resource_size rather than a verbose computation on
the end and start fields.

Signed-off-by: Zheng Yongjun <[email protected]>
---
drivers/mtd/devices/st_spi_fsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
index 1888523d9745..983999c020d6 100644
--- a/drivers/mtd/devices/st_spi_fsm.c
+++ b/drivers/mtd/devices/st_spi_fsm.c
@@ -924,7 +924,7 @@ static int stfsm_read_status(struct stfsm *fsm, uint8_t cmd,
BUG_ON(bytes != 1 && bytes != 2);

seq->seq_opc[0] = (SEQ_OPC_PADS_1 | SEQ_OPC_CYCLES(8) |
- SEQ_OPC_OPCODE(cmd)),
+ SEQ_OPC_OPCODE(cmd));

stfsm_load_seq(fsm, seq);

--
2.22.0

2021-01-06 14:54:01

by Miquel Raynal

Subject: Re: [PATCH -next] mtd: st_spi_fsm: use resource_size

Hello,

Zheng Yongjun <[email protected]> wrote on Wed, 6 Jan 2021
21:18:47 +0800:

> Use resource_size rather than a verbose computation on
> the end and start fields.
>
> Signed-off-by: Zheng Yongjun <[email protected]>
> ---
> drivers/mtd/devices/st_spi_fsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
> index 1888523d9745..983999c020d6 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -924,7 +924,7 @@ static int stfsm_read_status(struct stfsm *fsm, uint8_t cmd,
> BUG_ON(bytes != 1 && bytes != 2);
>
> seq->seq_opc[0] = (SEQ_OPC_PADS_1 | SEQ_OPC_CYCLES(8) |
> - SEQ_OPC_OPCODE(cmd)),
> + SEQ_OPC_OPCODE(cmd));
>
> stfsm_load_seq(fsm, seq);
>

Same remark again, description and actual change do not match.

Thanks,
Miquèl