2021-01-06 13:22:51

by Zheng Yongjun

Subject: [PATCH -next] video: fbdev: pxa3xx_gcu: use resource_size

Use resource_size rather than a verbose computation on
the end and start fields.

Signed-off-by: Zheng Yongjun <[email protected]>
---
drivers/video/fbdev/pxa3xx-gcu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
index 4279e13a3b58..1d26be9d1f2d 100644
--- a/drivers/video/fbdev/pxa3xx-gcu.c
+++ b/drivers/video/fbdev/pxa3xx-gcu.c
@@ -594,8 +594,8 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev)
* container_of(). This isn't really necessary as we have a fixed minor
* number anyway, but this is to avoid statics. */

- priv->misc_dev.minor = PXA3XX_GCU_MINOR,
- priv->misc_dev.name = DRV_NAME,
+ priv->misc_dev.minor = PXA3XX_GCU_MINOR;
+ priv->misc_dev.name = DRV_NAME;
priv->misc_dev.fops = &pxa3xx_gcu_miscdev_fops;

/* handle IO resources */
--
2.22.0

2021-01-06 13:45:16

by Geert Uytterhoeven

Subject: Re: [PATCH -next] video: fbdev: pxa3xx_gcu: use resource_size

Hi Zheng,

On Wed, Jan 6, 2021 at 2:23 PM Zheng Yongjun <[email protected]> wrote:
> Use resource_size rather than a verbose computation on
> the end and start fields.
>
> Signed-off-by: Zheng Yongjun <[email protected]>

Thanks for your patch!

But the one-line summary and patch description don't seem to match
with the actual change?

> --- a/drivers/video/fbdev/pxa3xx-gcu.c
> +++ b/drivers/video/fbdev/pxa3xx-gcu.c
> @@ -594,8 +594,8 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev)
> * container_of(). This isn't really necessary as we have a fixed minor
> * number anyway, but this is to avoid statics. */
>
> - priv->misc_dev.minor = PXA3XX_GCU_MINOR,
> - priv->misc_dev.name = DRV_NAME,
> + priv->misc_dev.minor = PXA3XX_GCU_MINOR;
> + priv->misc_dev.name = DRV_NAME;
> priv->misc_dev.fops = &pxa3xx_gcu_miscdev_fops;
>
> /* handle IO resources */

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds