2021-01-08 18:37:05

by Cristian Pop

Subject: [PATCH v5 1/3] dt-bindings: iio: dac: AD5766 yaml documentation

This adds device tree bindings for the AD5766 DAC.

Signed-off-by: Cristian Pop <[email protected]>
---
Changelog v5:
-rename to property to "output-range-voltage"
.../bindings/iio/dac/adi,ad5766.yaml | 64 +++++++++++++++++++
1 file changed, 64 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml

diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml
new file mode 100644
index 000000000000..1deace7c48b2
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright 2020 Analog Devices Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/dac/adi,ad5766.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD5766 DAC device driver
+
+maintainers:
+ - Cristian Pop <[email protected]>
+
+description: |
+ Bindings for the Analog Devices AD5766 current DAC device. Datasheet can be
+ found here:
+ https://www.analog.com/media/en/technical-documentation/data-sheets/ad5766-5767.pdf
+
+properties:
+ compatible:
+ enum:
+ - adi,ad5766
+ - adi,ad5767
+
+ output-range-volts:
+ description: Select converter output range.
+
+ reg:
+ maxItems: 1
+
+ spi-max-frequency:
+ maximum: 1000000
+
+ spi-cpol: true
+
+ reset-gpios:
+ description: GPIO spec for the RESET pin. If specified, it will be asserted
+ during driver probe. As the line is active low, it should be marked
+ GPIO_ACTIVE_LOW.
+ maxItems: 1
+
+required:
+ - compatible
+ - output-range-volts
+ - reg
+ - spi-max-frequency
+ - spi-cpol
+
+additionalProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ad5766@0 {
+ compatible = "adi,ad5766";
+ output-range-volts = <(-5) 5>;
+ reg = <0>;
+ spi-cpol;
+ spi-max-frequency = <1000000>;
+ reset-gpios = <&gpio 22 0>;
+ };
+ };
--
2.17.1

2021-01-11 19:57:54

by Rob Herring

Subject: Re: [PATCH v5 1/3] dt-bindings: iio: dac: AD5766 yaml documentation

On Fri, Jan 08, 2021 at 08:37:37PM +0200, Cristian Pop wrote:
> This adds device tree bindings for the AD5766 DAC.
>
> Signed-off-by: Cristian Pop <[email protected]>
> ---
> Changelog v5:
> -rename to property to "output-range-voltage"
> .../bindings/iio/dac/adi,ad5766.yaml | 64 +++++++++++++++++++
> 1 file changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml
> new file mode 100644
> index 000000000000..1deace7c48b2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5766.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2020 Analog Devices Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/dac/adi,ad5766.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD5766 DAC device driver
> +
> +maintainers:
> + - Cristian Pop <[email protected]>
> +
> +description: |
> + Bindings for the Analog Devices AD5766 current DAC device. Datasheet can be
> + found here:
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad5766-5767.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad5766
> + - adi,ad5767
> +
> + output-range-volts:

Use a unit defined in property-units.txt (-microvolt).

> + description: Select converter output range.
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 1000000
> +
> + spi-cpol: true
> +
> + reset-gpios:
> + description: GPIO spec for the RESET pin. If specified, it will be asserted
> + during driver probe. As the line is active low, it should be marked
> + GPIO_ACTIVE_LOW.

'asserted during driver probe' is a Linux implementation detail not
relevant to the binding.

> + maxItems: 1
> +
> +required:
> + - compatible
> + - output-range-volts
> + - reg
> + - spi-max-frequency
> + - spi-cpol
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ad5766@0 {
> + compatible = "adi,ad5766";
> + output-range-volts = <(-5) 5>;
> + reg = <0>;
> + spi-cpol;
> + spi-max-frequency = <1000000>;
> + reset-gpios = <&gpio 22 0>;
> + };
> + };
> --
> 2.17.1
>