2021-01-08 22:49:46

by Rikard Falkeborn

Subject: [PATCH] 9p: Constify static struct v9fs_attr_group

The only usage of v9fs_attr_group is to pass its address to
sysfs_create_group() and sysfs_create_group(), both which takes pointers
to const struct attribute_group. Make it const to allow the compiler to
put it in read-only memory.

Signed-off-by: Rikard Falkeborn <[email protected]>
---
fs/9p/v9fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
index 39def020a074..cdb99507ef33 100644
--- a/fs/9p/v9fs.c
+++ b/fs/9p/v9fs.c
@@ -583,7 +583,7 @@ static struct attribute *v9fs_attrs[] = {
NULL,
};

-static struct attribute_group v9fs_attr_group = {
+static const struct attribute_group v9fs_attr_group = {
.attrs = v9fs_attrs,
};

--
2.30.0

2021-01-08 23:18:56

by Dominique Martinet

Subject: Re: [PATCH] 9p: Constify static struct v9fs_attr_group

Rikard Falkeborn wrote on Fri, Jan 08, 2021 at 11:46:50PM +0100:
> The only usage of v9fs_attr_group is to pass its address to
> sysfs_create_group() and sysfs_create_group(), both which takes pointers
> to const struct attribute_group. Make it const to allow the compiler to
> put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <[email protected]>

Thanks, taking it.
--
Dominique