2021-01-10 23:21:19

by Alexandre Belloni

Subject: [PATCH 02/17] rtc: pl031: use RTC_FEATURE_ALARM

Clear RTC_FEATURE_ALARM instead of setting set_alarm, read_alarm and
alarm_irq_enable to NULL.

Signed-off-by: Alexandre Belloni <[email protected]>
---
drivers/rtc/rtc-pl031.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c
index 224bbf096262..7c3967df4f9a 100644
--- a/drivers/rtc/rtc-pl031.c
+++ b/drivers/rtc/rtc-pl031.c
@@ -352,12 +352,8 @@ static int pl031_probe(struct amba_device *adev, const struct amba_id *id)
}
}

- if (!adev->irq[0]) {
- /* When there's no interrupt, no point in exposing the alarm */
- ops->read_alarm = NULL;
- ops->set_alarm = NULL;
- ops->alarm_irq_enable = NULL;
- }
+ if (!adev->irq[0])
+ clear_bit(RTC_FEATURE_ALARM, ldata->rtc->features);

device_init_wakeup(&adev->dev, true);
ldata->rtc = devm_rtc_allocate_device(&adev->dev);
--
2.29.2

2021-01-11 22:04:06

by Linus Walleij

Subject: Re: [PATCH 02/17] rtc: pl031: use RTC_FEATURE_ALARM

On Mon, Jan 11, 2021 at 12:18 AM Alexandre Belloni
<[email protected]> wrote:

> Clear RTC_FEATURE_ALARM instead of setting set_alarm, read_alarm and
> alarm_irq_enable to NULL.
>
> Signed-off-by: Alexandre Belloni <[email protected]>

Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij