2021-01-11 10:52:07

by Xu, Yanfei

Subject: [PATCH] kthread: remove comments about old _do_fork() helper

From: Yanfei Xu <[email protected]>

The old _do_fork() helper has been removed in favor of kernel_clone().
Here correct some comments which still contain _do_fork()

Signed-off-by: Yanfei Xu <[email protected]>
---
include/trace/events/sched.h | 2 +-
kernel/kthread.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
index 5039af667645..cbe3e152d24c 100644
--- a/include/trace/events/sched.h
+++ b/include/trace/events/sched.h
@@ -366,7 +366,7 @@ TRACE_EVENT(sched_process_wait,
);

/*
- * Tracepoint for do_fork:
+ * Tracepoint for kernel_clone:
*/
TRACE_EVENT(sched_process_fork,

diff --git a/kernel/kthread.c b/kernel/kthread.c
index a5eceecd4513..fb9c3dcbb68d 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -294,7 +294,7 @@ static int kthread(void *_create)
do_exit(ret);
}

-/* called from do_fork() to get node information for about to be created task */
+/* called from kernel_clone() to get node information for about to be created task */
int tsk_fork_get_node(struct task_struct *tsk)
{
#ifdef CONFIG_NUMA
--
2.18.2

2021-01-11 11:28:40

by Christian Brauner

Subject: Re: [PATCH] kthread: remove comments about old _do_fork() helper

On Mon, Jan 11, 2021 at 06:48:07PM +0800, [email protected] wrote:
> From: Yanfei Xu <[email protected]>
>
> The old _do_fork() helper has been removed in favor of kernel_clone().
> Here correct some comments which still contain _do_fork()
>
> Signed-off-by: Yanfei Xu <[email protected]>
> ---

Acked-by: Christian Brauner <[email protected]>

Thanks, applied.