2021-01-12 16:18:38

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] crypto: keembay - CRYPTO_DEV_KEEMBAY_OCS_HCU should depend on ARCH_KEEMBAY

The Intel Keem Bay Offload and Crypto Subsystem (OCS) Hash Control Unit
(HCU) is only present on Intel Keem Bay SoCs. Hence add a dependency on
ARCH_KEEMBAY, to prevent asking the user about this driver when
configuring a kernel without Intel Keem Bay platform support.

Fixes: 472b04444cd39e16 ("crypto: keembay - Add Keem Bay OCS HCU driver")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/crypto/keembay/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/keembay/Kconfig b/drivers/crypto/keembay/Kconfig
index e45f1b039380feaa..ce0516e32ce4ff82 100644
--- a/drivers/crypto/keembay/Kconfig
+++ b/drivers/crypto/keembay/Kconfig
@@ -41,9 +41,9 @@ config CRYPTO_DEV_KEEMBAY_OCS_AES_SM4_CTS

config CRYPTO_DEV_KEEMBAY_OCS_HCU
tristate "Support for Intel Keem Bay OCS HCU HW acceleration"
+ depends on ARCH_KEEMBAY || COMPILE_TEST
select CRYPTO_HASH
select CRYPTO_ENGINE
- depends on OF || COMPILE_TEST
help
Support for Intel Keem Bay Offload and Crypto Subsystem (OCS) Hash
Control Unit (HCU) hardware acceleration for use with Crypto API.
--
2.25.1


2021-01-14 05:34:11

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: keembay - CRYPTO_DEV_KEEMBAY_OCS_HCU should depend on ARCH_KEEMBAY

On Tue, Jan 12, 2021 at 05:15:40PM +0100, Geert Uytterhoeven wrote:
> The Intel Keem Bay Offload and Crypto Subsystem (OCS) Hash Control Unit
> (HCU) is only present on Intel Keem Bay SoCs. Hence add a dependency on
> ARCH_KEEMBAY, to prevent asking the user about this driver when
> configuring a kernel without Intel Keem Bay platform support.
>
> Fixes: 472b04444cd39e16 ("crypto: keembay - Add Keem Bay OCS HCU driver")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/crypto/keembay/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

There is already a patch in the queue that fixes this.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt