2021-01-15 07:02:53

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warnings after merge of the drm-misc tree

---

Hi all,

After merging the drm-misc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/gpu/drm/amd/amdgpu/amdgpu_display.c: In function 'amdgpu_display_user_framebuffer_create':
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:929:24: warning: unused variable 'adev' [-Wunused-variable]
929 | struct amdgpu_device *adev = drm_to_adev(dev);
| ^~~~

Introduced by commit

8f66090b7bb7 ("drm/amdgpu: Remove references to struct drm_device.pdev")

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function 'amdgpu_device_resize_fb_bar':
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1109:6: warning: unused variable 'space_needed' [-Wunused-variable]
1109 | u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
| ^~~~~~~~~~~~

Introduced by commit

453f617a30aa ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2021-01-15 15:06:28

by Nirmoy

[permalink] [raw]

Subject: Re: linux-next: build warnings after merge of the drm-misc tree

---

Hi Stephen,

On 1/15/21 2:23 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the drm-misc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c: In function 'amdgpu_display_user_framebuffer_create':
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:929:24: warning: unused variable 'adev' [-Wunused-variable]
> 929 | struct amdgpu_device *adev = drm_to_adev(dev);
> | ^~~~
>
> Introduced by commit
>
> 8f66090b7bb7 ("drm/amdgpu: Remove references to struct drm_device.pdev")


I just sent a patch for this.


>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function 'amdgpu_device_resize_fb_bar':
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1109:6: warning: unused variable 'space_needed' [-Wunused-variable]
> 1109 | u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
> | ^~~~~~~~~~~~
>
> Introduced by commit
>
> 453f617a30aa ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")


We have a fix already merged in drm-misc-next for this.


Thanks,

Nirmoy

>