2021-01-18 01:26:36

by Chengyang Fan

Subject: [PATCH] resource: Remove unneeded semicolon

Remove a superfluous semicolon after function definition.

Signed-off-by: Chengyang Fan <[email protected]>
---
include/linux/ioport.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/ioport.h b/include/linux/ioport.h
index fe48b7840665..803c10f6a6df 100644
--- a/include/linux/ioport.h
+++ b/include/linux/ioport.h
@@ -337,7 +337,7 @@ static inline void irqresource_disabled(struct resource *res, u32 irq)
#ifdef CONFIG_IO_STRICT_DEVMEM
void revoke_devmem(struct resource *res);
#else
-static inline void revoke_devmem(struct resource *res) { };
+static inline void revoke_devmem(struct resource *res) { }
#endif

#endif /* __ASSEMBLY__ */
--
2.25.1

2021-01-19 22:46:27

by Wysocki, Rafael J

Subject: Re: [PATCH] resource: Remove unneeded semicolon

On 1/18/2021 2:50 AM, Chengyang Fan wrote:
> Remove a superfluous semicolon after function definition.
>
> Signed-off-by: Chengyang Fan <[email protected]>
> ---
> include/linux/ioport.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> index fe48b7840665..803c10f6a6df 100644
> --- a/include/linux/ioport.h
> +++ b/include/linux/ioport.h
> @@ -337,7 +337,7 @@ static inline void irqresource_disabled(struct resource *res, u32 irq)
> #ifdef CONFIG_IO_STRICT_DEVMEM
> void revoke_devmem(struct resource *res);
> #else
> -static inline void revoke_devmem(struct resource *res) { };
> +static inline void revoke_devmem(struct resource *res) { }
> #endif
>
> #endif /* __ASSEMBLY__ */

The patch is fine AFAICS, so

Reviewed-by: Rafael J. Wysocki <[email protected]>

but I'm not sure why it has been sent to me.

It would be better to send it to Greg instead.

Thanks!