2021-01-18 14:23:48

by Mike Leach

Subject: Re: [PATCH V2] coresight: etm4x: add AMBA id for Cortex-A55 and Cortex-A75

On Mon, 18 Jan 2021 at 06:56, Chunyan Zhang <[email protected]> wrote:
>
> From: Chunyan Zhang <[email protected]>
>
> Add AMBA UCI id to support Cortex-A55(Ananke) and Cortex-A75(Promethus).
>
> Signed-off-by: Bin Ji <[email protected]>
> Signed-off-by: Chunyan Zhang <[email protected]>
> ---
> Changes since v1:
> * Addressed Mike's comments - changed to use CS_AMBA_UCI_ID().
> ---
> drivers/hwtracing/coresight/coresight-etm4x-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> index b20b6ff17cf6..8c4b0c46c8f3 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> @@ -1713,6 +1713,8 @@ static const struct amba_id etm4_ids[] = {
> CS_AMBA_ID(0x000bb95a), /* Cortex-A72 */
> CS_AMBA_ID(0x000bb959), /* Cortex-A73 */
> CS_AMBA_UCI_ID(0x000bb9da, uci_id_etm4),/* Cortex-A35 */
> + CS_AMBA_UCI_ID(0x000bbd05, uci_id_etm4),/* Cortex-A55 */
> + CS_AMBA_UCI_ID(0x000bbd0a, uci_id_etm4),/* Cortex-A75 */
> CS_AMBA_UCI_ID(0x000bbd0c, uci_id_etm4),/* Neoverse N1 */
> CS_AMBA_UCI_ID(0x000f0205, uci_id_etm4),/* Qualcomm Kryo */
> CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */
> --
> 2.25.1
>

Reviewed by: Mike Leach <[email protected]>
--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK

2021-01-18 16:52:50

by Mathieu Poirier

Subject: Re: [PATCH V2] coresight: etm4x: add AMBA id for Cortex-A55 and Cortex-A75

On Mon, Jan 18, 2021 at 02:19:25PM +0000, Mike Leach wrote:
> On Mon, 18 Jan 2021 at 06:56, Chunyan Zhang <[email protected]> wrote:
> >
> > From: Chunyan Zhang <[email protected]>
> >
> > Add AMBA UCI id to support Cortex-A55(Ananke) and Cortex-A75(Promethus).
> >
> > Signed-off-by: Bin Ji <[email protected]>
> > Signed-off-by: Chunyan Zhang <[email protected]>
> > ---
> > Changes since v1:
> > * Addressed Mike's comments - changed to use CS_AMBA_UCI_ID().
> > ---
> > drivers/hwtracing/coresight/coresight-etm4x-core.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> > index b20b6ff17cf6..8c4b0c46c8f3 100644
> > --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
> > +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> > @@ -1713,6 +1713,8 @@ static const struct amba_id etm4_ids[] = {
> > CS_AMBA_ID(0x000bb95a), /* Cortex-A72 */
> > CS_AMBA_ID(0x000bb959), /* Cortex-A73 */
> > CS_AMBA_UCI_ID(0x000bb9da, uci_id_etm4),/* Cortex-A35 */
> > + CS_AMBA_UCI_ID(0x000bbd05, uci_id_etm4),/* Cortex-A55 */
> > + CS_AMBA_UCI_ID(0x000bbd0a, uci_id_etm4),/* Cortex-A75 */
> > CS_AMBA_UCI_ID(0x000bbd0c, uci_id_etm4),/* Neoverse N1 */
> > CS_AMBA_UCI_ID(0x000f0205, uci_id_etm4),/* Qualcomm Kryo */
> > CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */
> > --
> > 2.25.1
> >
>
> Reviewed by: Mike Leach <[email protected]>

I have applied this patch.

Thanks,
Mathieu

> --
> Mike Leach
> Principal Engineer, ARM Ltd.
> Manchester Design Centre. UK