2021-01-20 05:11:58

by Drew Fustini

[permalink] [raw]
Subject: [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins

Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins

Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2")
Reported-by: Emmanuel Vadot <[email protected]>
Link: https://lore.kernel.org/linux-gpio/[email protected]/
Cc: Tony Lindgren <[email protected]>
Signed-off-by: Drew Fustini <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
index f903eb4471f8..bb9999119314 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
@@ -8,7 +8,7 @@ Required properties:
- reg : offset and length of the register set for the mux registers

- #pinctrl-cells : number of cells in addition to the index, set to 1
- for pinctrl-single,pins and 2 for pinctrl-single,bits
+ or 2 for pinctrl-single,pins and set to 2 for pinctrl-single,bits

- pinctrl-single,register-width : pinmux register access width in bits

--
2.25.1


2021-01-20 08:07:54

by Emmanuel Vadot

[permalink] [raw]
Subject: Re: [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins

On Tue, 19 Jan 2021 21:03:44 -0800
Drew Fustini <[email protected]> wrote:

> Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins
>
> Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2")
> Reported-by: Emmanuel Vadot <[email protected]>
> Link: https://lore.kernel.org/linux-gpio/[email protected]/
> Cc: Tony Lindgren <[email protected]>
> Signed-off-by: Drew Fustini <[email protected]>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
> index f903eb4471f8..bb9999119314 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
> @@ -8,7 +8,7 @@ Required properties:
> - reg : offset and length of the register set for the mux registers
>
> - #pinctrl-cells : number of cells in addition to the index, set to 1
> - for pinctrl-single,pins and 2 for pinctrl-single,bits
> + or 2 for pinctrl-single,pins and set to 2 for pinctrl-single,bits
>
> - pinctrl-single,register-width : pinmux register access width in bits
>
> --
> 2.25.1
>

Reviewed-by: Emmanuel Vadot <[email protected]>

Thanks, now the docs make more sense :)

--
Emmanuel Vadot <[email protected]> <[email protected]>

2021-01-21 07:44:31

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins

* Emmanuel Vadot <[email protected]> [210120 08:01]:
> On Tue, 19 Jan 2021 21:03:44 -0800
> Drew Fustini <[email protected]> wrote:
>
> > Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins
...

> Reviewed-by: Emmanuel Vadot <[email protected]>
>
> Thanks, now the docs make more sense :)

Looks good to me too:

Reviewed-by: Tony Lindgren <[email protected]>

2021-01-22 13:24:01

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins

On Wed, Jan 20, 2021 at 6:04 AM Drew Fustini <[email protected]> wrote:

> Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins
>
> Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2")
> Reported-by: Emmanuel Vadot <[email protected]>
> Link: https://lore.kernel.org/linux-gpio/[email protected]/
> Cc: Tony Lindgren <[email protected]>
> Signed-off-by: Drew Fustini <[email protected]>

Patch applied!

Yours,
Linus Walleij