2021-01-22 18:15:57

by Johan Jonker

Subject: [PATCH] arm64: dts: rockchip: add device_type property to rk3399 pcie node

A test with the command below gives for example this error:
/arch/arm64/boot/dts/rockchip/rk3399-rock960.dt.yaml:
pcie@f8000000: 'device_type' is a required property

Fix this by adding a device_type property to the rk3399 pcie node.

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/
schemas/pci/pci-bus.yaml

Signed-off-by: Johan Jonker <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 28459d194..6c571fee8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -252,6 +252,7 @@
<0 0 0 2 &pcie0_intc 1>,
<0 0 0 3 &pcie0_intc 2>,
<0 0 0 4 &pcie0_intc 3>;
+ device_type = "pci";
linux,pci-domain = <0>;
max-link-speed = <1>;
msi-map = <0x0 &its 0x0 0x1000>;
--
2.11.0

2021-01-25 23:57:05

by Heiko Stuebner

Subject: Re: [PATCH] arm64: dts: rockchip: add device_type property to rk3399 pcie node

Am Freitag, 22. Januar 2021, 19:05:59 CET schrieb Johan Jonker:
> A test with the command below gives for example this error:
> /arch/arm64/boot/dts/rockchip/rk3399-rock960.dt.yaml:
> pcie@f8000000: 'device_type' is a required property
>
> Fix this by adding a device_type property to the rk3399 pcie node.
>
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/
> schemas/pci/pci-bus.yaml
>
> Signed-off-by: Johan Jonker <[email protected]>

already done in
https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.11-armsoc/dtsfixes&id=43f20b1c6140896916f4e91aacc166830a7ba849