2021-01-23 15:05:06

by Qiujun Huang

Subject: [PATCH] PHY: Ingenic: compile phy-ingenic-usb only if it was enabled

We should compile this driver only if we opened PHY_INGENIC_USB.

Signed-off-by: Qiujun Huang <[email protected]>
---
drivers/phy/ingenic/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/ingenic/Makefile b/drivers/phy/ingenic/Makefile
index 65d5ea00fc9d..a00306651423 100644
--- a/drivers/phy/ingenic/Makefile
+++ b/drivers/phy/ingenic/Makefile
@@ -1,2 +1,2 @@
# SPDX-License-Identifier: GPL-2.0
-obj-y += phy-ingenic-usb.o
+obj-$(PHY_INGENIC_USB) += phy-ingenic-usb.o
--
2.25.1

2021-01-24 08:39:39

by Paul Cercueil

Subject: Re: [PATCH] PHY: Ingenic: compile phy-ingenic-usb only if it was enabled

Hi, thank you for your patch.


Le sam. 23 janv. 2021 ? 23:01, Qiujun Huang <[email protected]> a
?crit :
> We should compile this driver only if we opened PHY_INGENIC_USB.

'opened' -> 'enable'.

> Signed-off-by: Qiujun Huang <[email protected]>

You will need to add a Fixes: tag and Cc linux-stable, since the
problem is already in 5.10.

Cheers,
-Paul

> ---
> drivers/phy/ingenic/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/ingenic/Makefile
> b/drivers/phy/ingenic/Makefile
> index 65d5ea00fc9d..a00306651423 100644
> --- a/drivers/phy/ingenic/Makefile
> +++ b/drivers/phy/ingenic/Makefile
> @@ -1,2 +1,2 @@
> # SPDX-License-Identifier: GPL-2.0
> -obj-y += phy-ingenic-usb.o
> +obj-$(PHY_INGENIC_USB) += phy-ingenic-usb.o
> --
> 2.25.1
>